Re: [PATCH v4 1/4] dt-bindings: net: bluetooth: qca: Expand firmware-name property

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/12/2024 11:16, Cheng Jiang (IOE) wrote:
> Hi Krzysztof,
> 
> On 12/11/2024 5:48 PM, Krzysztof Kozlowski wrote:
>> On 11/12/2024 10:39, Cheng Jiang (IOE) wrote:
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>>>> index 7bb68311c..2782d2325 100644
>>>>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>>>> @@ -101,7 +101,10 @@ properties:
>>>>>    max-speed: true
>>>>>  
>>>>>    firmware-name:
>>>>> -    description: specify the name of nvm firmware to load
>>>>> +    description:
>>>>> +      If one item is present, specify the name of the NVM firmware to load.
>>>>> +      If two items are present, the first item specifies the name of the NVM,
>>>>> +      and the second specifies the name of the rampatch firmware to load.
>>>>
>>>> Don't repeat constraints in free form text. Use proper constraints so
>>>> you can validate your DTS. And then actually do validate your DTS...
>>>>
>>> It seems unnecessary to add this description, so I will drop this change. Is that okay?
>>
>> You need to list the items and describe them. See how all other bindings
>> do it.
>>
> The firmware names are not fixed strings; they vary depending on the chip, board, or platform.

Instead of replying immediately and pushing this back again on us, read
other bindings. There are nowhere "fixed strings".


Best regards,
Krzysztof