From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Cheng Jiang (IOE)" <quic_chejiang@quicinc.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
Rocky Liao <quic_rjliao@quicinc.com>,
linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
quic_jiaymao@quicinc.com, quic_shuaz@quicinc.com,
quic_zijuhu@quicinc.com, quic_mohamull@quicinc.com
Subject: Re: [PATCH v4 1/4] dt-bindings: net: bluetooth: qca: Expand firmware-name property
Date: Wed, 11 Dec 2024 10:48:15 +0100 [thread overview]
Message-ID: <f818f089-0490-42da-9aee-1a7006c11978@kernel.org> (raw)
In-Reply-To: <62afbaea-67b1-4572-9e78-d1dbe5fae20a@quicinc.com>
On 11/12/2024 10:39, Cheng Jiang (IOE) wrote:
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>> index 7bb68311c..2782d2325 100644
>>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>> @@ -101,7 +101,10 @@ properties:
>>> max-speed: true
>>>
>>> firmware-name:
>>> - description: specify the name of nvm firmware to load
>>> + description:
>>> + If one item is present, specify the name of the NVM firmware to load.
>>> + If two items are present, the first item specifies the name of the NVM,
>>> + and the second specifies the name of the rampatch firmware to load.
>>
>> Don't repeat constraints in free form text. Use proper constraints so
>> you can validate your DTS. And then actually do validate your DTS...
>>
> It seems unnecessary to add this description, so I will drop this change. Is that okay?
You need to list the items and describe them. See how all other bindings
do it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-11 9:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 15:16 [PATCH v4 0/3] Expand firmware-name property to load specific Cheng Jiang
2024-12-10 15:16 ` [PATCH v4 1/4] dt-bindings: net: bluetooth: qca: Expand firmware-name property Cheng Jiang
2024-12-11 8:53 ` Krzysztof Kozlowski
2024-12-11 9:39 ` Cheng Jiang (IOE)
2024-12-11 9:48 ` Krzysztof Kozlowski [this message]
2024-12-11 10:16 ` Cheng Jiang (IOE)
2024-12-11 19:28 ` Dmitry Baryshkov
2024-12-12 5:56 ` Cheng Jiang (IOE)
2024-12-12 7:16 ` Krzysztof Kozlowski
2024-12-12 10:16 ` Cheng Jiang (IOE)
2024-12-10 15:16 ` [PATCH v4 2/4] Bluetooth: qca: Add support in firmware-name to load board specific nvm Cheng Jiang
2024-12-10 15:28 ` Dmitry Baryshkov
2024-12-11 5:53 ` Cheng Jiang (IOE)
2024-12-10 15:16 ` [PATCH v4 3/4] Bluetooth: qca: Expand firmware-name to load specific rampatch Cheng Jiang
2024-12-10 15:16 ` [PATCH v4 4/4] arm64: dts: qcom: sa8775p-ride: Add firmware-name in BT node Cheng Jiang
2024-12-11 8:53 ` [PATCH v4 0/3] Expand firmware-name property to load specific Krzysztof Kozlowski
2024-12-11 9:37 ` Cheng Jiang (IOE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f818f089-0490-42da-9aee-1a7006c11978@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_chejiang@quicinc.com \
--cc=quic_jiaymao@quicinc.com \
--cc=quic_mohamull@quicinc.com \
--cc=quic_rjliao@quicinc.com \
--cc=quic_shuaz@quicinc.com \
--cc=quic_zijuhu@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox