From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Odelu Kukatla <quic_okukatla@quicinc.com>, djakov@kernel.org
Cc: rafael@kernel.org, corbet@lwn.net, linux-pm@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_viveka@quicinc.com, peterz@infradead.org,
quic_mdtipton@quicinc.com, linux-arm-msm@vger.kernel.org,
konrad.dybcio@linaro.org
Subject: Re: [PATCH v2 2/4] interconnect: qcom: sc7280: enable QoS configuration
Date: Mon, 5 Feb 2024 16:12:10 +0100 [thread overview]
Message-ID: <ecdf3c46-77ba-443f-9d64-caf4dc67fc3a@linaro.org> (raw)
In-Reply-To: <20240205145606.16936-3-quic_okukatla@quicinc.com>
On 05/02/2024 15:56, Odelu Kukatla wrote:
> Enable QoS configuration for the master ports with predefined values
> for priority and urgency.
>
> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com>
> ---
> drivers/interconnect/qcom/sc7280.c | 332 +++++++++++++++++++++++++++++
> 1 file changed, 332 insertions(+)
>
> diff --git a/drivers/interconnect/qcom/sc7280.c b/drivers/interconnect/qcom/sc7280.c
> index 7d33694368e8..438f927935e5 100644
> --- a/drivers/interconnect/qcom/sc7280.c
> +++ b/drivers/interconnect/qcom/sc7280.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
> *
> */
>
> @@ -16,29 +17,53 @@
> #include "icc-rpmh.h"
> #include "sc7280.h"
>
> +static struct qcom_icc_qosbox qhm_qspi_qos = {
Why this cannot be const?
> + .num_ports = 1,
> + .port_offsets = { 0x7000 },
> + .prio = 2,
> + .urg_fwd = 0,
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-05 15:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 14:56 [PATCH v2 0/4] Add support for QoS configuration Odelu Kukatla
2024-02-05 14:56 ` [PATCH v2 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support Odelu Kukatla
2024-02-05 15:08 ` Dmitry Baryshkov
2024-02-22 10:46 ` Odelu Kukatla
2024-02-06 7:55 ` kernel test robot
2024-02-05 14:56 ` [PATCH v2 2/4] interconnect: qcom: sc7280: enable QoS configuration Odelu Kukatla
2024-02-05 15:12 ` Krzysztof Kozlowski [this message]
2024-02-22 10:50 ` Odelu Kukatla
2024-02-05 14:56 ` [PATCH v2 3/4] dt-bindings: interconnect: add clock property to configure QoS on SC7280 Odelu Kukatla
2024-02-05 15:10 ` Krzysztof Kozlowski
2024-02-22 10:50 ` Odelu Kukatla
2024-02-05 14:56 ` [PATCH v2 4/4] arm64: dts: qcom: sc7280: Add clocks for QoS configuration Odelu Kukatla
2024-02-06 9:07 ` [PATCH v2 0/4] Add support " Konrad Dybcio
2024-02-22 10:54 ` Odelu Kukatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecdf3c46-77ba-443f-9d64-caf4dc67fc3a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=corbet@lwn.net \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=quic_viveka@quicinc.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox