Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Odelu Kukatla <quic_okukatla@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	<djakov@kernel.org>
Cc: <rafael@kernel.org>, <corbet@lwn.net>, <linux-pm@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<quic_viveka@quicinc.com>, <peterz@infradead.org>,
	<quic_mdtipton@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
	<konrad.dybcio@linaro.org>
Subject: Re: [PATCH v2 3/4] dt-bindings: interconnect: add clock property to configure QoS on SC7280
Date: Thu, 22 Feb 2024 16:20:05 +0530	[thread overview]
Message-ID: <fbdcd6e6-9d57-47d8-a462-908a03b373ea@quicinc.com> (raw)
In-Reply-To: <e473937e-2d8e-47e3-bffd-025b87769335@linaro.org>



On 2/5/2024 8:40 PM, Krzysztof Kozlowski wrote:
> On 05/02/2024 15:56, Odelu Kukatla wrote:
>> Added clock property to enable clocks required for accessing
>> qos registers.
> 
> I have no idea how you came up with that CC list. It makes no sense.
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline), work on fork of kernel
> (don't, instead use mainline) or you ignore some maintainers (really
> don't). Just use b4 and everything should be fine, although remember
> about `b4 prep --auto-to-cc` if you added new patches to the patchset.
> 
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time, thus I will skip this patch entirely till you follow
> the process allowing the patch to be tested.
> 
> Please kindly resend and include all necessary To/Cc entries. Tomorrow.
> 
> Best regards,
> Krzysztof
> 

Thanks for your comments. I used latest tree only, but looks like i made a mistake while sending it.
I will use scripts/get_maintainer.pl script to get the list for next revision with other's comments addressed.

Thanks,
Odelu

  reply	other threads:[~2024-02-22 10:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-05 14:56 [PATCH v2 0/4] Add support for QoS configuration Odelu Kukatla
2024-02-05 14:56 ` [PATCH v2 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support Odelu Kukatla
2024-02-05 15:08   ` Dmitry Baryshkov
2024-02-22 10:46     ` Odelu Kukatla
2024-02-06  7:55   ` kernel test robot
2024-02-05 14:56 ` [PATCH v2 2/4] interconnect: qcom: sc7280: enable QoS configuration Odelu Kukatla
2024-02-05 15:12   ` Krzysztof Kozlowski
2024-02-22 10:50     ` Odelu Kukatla
2024-02-05 14:56 ` [PATCH v2 3/4] dt-bindings: interconnect: add clock property to configure QoS on SC7280 Odelu Kukatla
2024-02-05 15:10   ` Krzysztof Kozlowski
2024-02-22 10:50     ` Odelu Kukatla [this message]
2024-02-05 14:56 ` [PATCH v2 4/4] arm64: dts: qcom: sc7280: Add clocks for QoS configuration Odelu Kukatla
2024-02-06  9:07 ` [PATCH v2 0/4] Add support " Konrad Dybcio
2024-02-22 10:54   ` Odelu Kukatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbdcd6e6-9d57-47d8-a462-908a03b373ea@quicinc.com \
    --to=quic_okukatla@quicinc.com \
    --cc=corbet@lwn.net \
    --cc=djakov@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=quic_mdtipton@quicinc.com \
    --cc=quic_viveka@quicinc.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox