From: Zijun Hu <zijun.hu@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com,
trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
20260224-knp-dts-misc-v6-0-79d20dab8a60@oss.qualcomm.com
Subject: Re: [PATCH 4/6] arm64: dts: qcom: kaanapali-mtp: Enable bluetooth and Wifi
Date: Wed, 25 Mar 2026 18:59:41 +0800 [thread overview]
Message-ID: <ee38eaeb-d408-4228-b7a8-bc2d6e4ef056@oss.qualcomm.com> (raw)
In-Reply-To: <hyy65v74scdekci3kdowxdcujbmoeyx3vxv6dahvif6rzhloxi@rirggsitayqv>
On 3/25/2026 3:08 PM, Dmitry Baryshkov wrote:
> On Wed, Mar 25, 2026 at 02:40:19PM +0800, Zijun Hu wrote:
>> On 3/24/2026 9:16 AM, Dmitry Baryshkov wrote:
>>>> +
>>>> + wcn7850-pmu {
>>>> + compatible = "qcom,wcn7850-pmu";
>>>> +
>>>> + pinctrl-0 = <&bt_default>, <&sw_ctrl_default>, <&wlan_en>;
>>>> + pinctrl-names = "default";
>>>> +
>>>> + bt-enable-gpios = <&pmh0104_j_e1_gpios 5 GPIO_ACTIVE_HIGH>;
>>>> + wlan-enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>;
>>> swctrl-gpios?
>>
>> it is '<&sw_ctrl_default>' within 'pinctrl-0' above.
>> the input pin is not used by power sequencing driver.
>> just give it some default configurations here.
>
> Please don't mix hardware description and the driver. If the pin is
> wired, let's describe it in DT.
>
give comments about that pin in this dts file ?
or give a seperated patch to describe the pin in DT binding schema of "qcom,wcn7850-pmu"?
next prev parent reply other threads:[~2026-03-25 10:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 6:19 [PATCH 0/6] arm64: dts: qcom: kaanapali: Add PMIC dependent features Jingyi Wang
2026-03-23 6:19 ` [PATCH 1/6] arm64: dts: qcom: kaanapali: Add PMIC devices Jingyi Wang
2026-03-24 1:12 ` Dmitry Baryshkov
2026-03-25 11:04 ` Jishnu Prakash
2026-03-23 6:19 ` [PATCH 2/6] arm64: dts: qcom: kaanapali-mtp: Add PMIC support Jingyi Wang
2026-03-24 1:13 ` Dmitry Baryshkov
2026-03-25 11:05 ` Jishnu Prakash
2026-03-23 6:19 ` [PATCH 3/6] arm64: dts: qcom: kaanapali-qrd: " Jingyi Wang
2026-03-24 1:14 ` Dmitry Baryshkov
2026-03-23 6:19 ` [PATCH 4/6] arm64: dts: qcom: kaanapali-mtp: Enable bluetooth and Wifi Jingyi Wang
2026-03-24 1:16 ` Dmitry Baryshkov
2026-03-25 6:40 ` Zijun Hu
2026-03-25 7:08 ` Dmitry Baryshkov
2026-03-25 10:59 ` Zijun Hu [this message]
2026-03-25 11:40 ` Dmitry Baryshkov
2026-03-26 3:19 ` Zijun Hu
2026-03-26 4:10 ` Dmitry Baryshkov
2026-03-26 5:15 ` Zijun Hu
2026-03-30 11:53 ` Dmitry Baryshkov
2026-04-01 10:39 ` Zijun Hu
2026-04-01 11:08 ` Dmitry Baryshkov
2026-04-01 13:34 ` Zijun Hu
2026-04-01 14:07 ` Dmitry Baryshkov
2026-04-07 6:49 ` Zijun Hu
2026-03-23 6:19 ` [PATCH 5/6] arm64: dts: qcom: kaanapali: add display hardware devices Jingyi Wang
2026-03-24 1:20 ` Dmitry Baryshkov
2026-03-26 2:37 ` yuanjiey
2026-03-26 4:11 ` Dmitry Baryshkov
2026-03-23 6:19 ` [PATCH 6/6] arm64: dts: qcom: kaanapali-mtp: Enable display DSI devices Jingyi Wang
2026-03-24 1:25 ` Dmitry Baryshkov
2026-03-26 3:13 ` yuanjiey
2026-03-26 4:22 ` Dmitry Baryshkov
2026-03-23 14:38 ` [PATCH 0/6] arm64: dts: qcom: kaanapali: Add PMIC dependent features Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee38eaeb-d408-4228-b7a8-bc2d6e4ef056@oss.qualcomm.com \
--to=zijun.hu@oss.qualcomm.com \
--cc=20260224-knp-dts-misc-v6-0-79d20dab8a60@oss.qualcomm.com \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tingwei.zhang@oss.qualcomm.com \
--cc=trilok.soni@oss.qualcomm.com \
--cc=yijie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox