* [PATCH] arm64: dts: qcom: sa8775p: Fix the size of 'addr_space' regions
@ 2024-11-28 14:51 Manivannan Sadhasivam
2024-11-28 21:58 ` Konrad Dybcio
2024-12-02 15:50 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2024-11-28 14:51 UTC (permalink / raw)
To: andersson, konradybcio, robh, krzk+dt, conor+dt
Cc: linux-arm-msm, devicetree, linux-kernel, Manivannan Sadhasivam,
stable
For both the controller instances, size of the 'addr_space' region should
be 0x1fe00000 as per the hardware memory layout.
Otherwise, endpoint drivers cannot request even reasonable BAR size of 1MB.
Cc: stable@vger.kernel.org # 6.11
Fixes: c5f5de8434ec ("arm64: dts: qcom: sa8775p: Add ep pcie1 controller node")
Fixes: 1924f5518224 ("arm64: dts: qcom: sa8775p: Add ep pcie0 controller node")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index e8dbc8d820a6..320a94dcac5c 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -5587,7 +5587,7 @@ pcie0_ep: pcie-ep@1c00000 {
<0x0 0x40000000 0x0 0xf20>,
<0x0 0x40000f20 0x0 0xa8>,
<0x0 0x40001000 0x0 0x4000>,
- <0x0 0x40200000 0x0 0x100000>,
+ <0x0 0x40200000 0x0 0x1fe00000>,
<0x0 0x01c03000 0x0 0x1000>,
<0x0 0x40005000 0x0 0x2000>;
reg-names = "parf", "dbi", "elbi", "atu", "addr_space",
@@ -5744,7 +5744,7 @@ pcie1_ep: pcie-ep@1c10000 {
<0x0 0x60000000 0x0 0xf20>,
<0x0 0x60000f20 0x0 0xa8>,
<0x0 0x60001000 0x0 0x4000>,
- <0x0 0x60200000 0x0 0x100000>,
+ <0x0 0x60200000 0x0 0x1fe00000>,
<0x0 0x01c13000 0x0 0x1000>,
<0x0 0x60005000 0x0 0x2000>;
reg-names = "parf", "dbi", "elbi", "atu", "addr_space",
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sa8775p: Fix the size of 'addr_space' regions
2024-11-28 14:51 [PATCH] arm64: dts: qcom: sa8775p: Fix the size of 'addr_space' regions Manivannan Sadhasivam
@ 2024-11-28 21:58 ` Konrad Dybcio
2024-12-02 15:50 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2024-11-28 21:58 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson, konradybcio, robh, krzk+dt,
conor+dt
Cc: linux-arm-msm, devicetree, linux-kernel, stable
On 28.11.2024 3:51 PM, Manivannan Sadhasivam wrote:
> For both the controller instances, size of the 'addr_space' region should
> be 0x1fe00000 as per the hardware memory layout.
>
> Otherwise, endpoint drivers cannot request even reasonable BAR size of 1MB.
>
> Cc: stable@vger.kernel.org # 6.11
> Fixes: c5f5de8434ec ("arm64: dts: qcom: sa8775p: Add ep pcie1 controller node")
> Fixes: 1924f5518224 ("arm64: dts: qcom: sa8775p: Add ep pcie0 controller node")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sa8775p: Fix the size of 'addr_space' regions
2024-11-28 14:51 [PATCH] arm64: dts: qcom: sa8775p: Fix the size of 'addr_space' regions Manivannan Sadhasivam
2024-11-28 21:58 ` Konrad Dybcio
@ 2024-12-02 15:50 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-12-02 15:50 UTC (permalink / raw)
To: konradybcio, robh, krzk+dt, conor+dt, Manivannan Sadhasivam
Cc: linux-arm-msm, devicetree, linux-kernel, stable
On Thu, 28 Nov 2024 20:21:47 +0530, Manivannan Sadhasivam wrote:
> For both the controller instances, size of the 'addr_space' region should
> be 0x1fe00000 as per the hardware memory layout.
>
> Otherwise, endpoint drivers cannot request even reasonable BAR size of 1MB.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sa8775p: Fix the size of 'addr_space' regions
commit: e60b14f47d779edc38bc1f14d2c995d477cec6f9
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-02 15:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-28 14:51 [PATCH] arm64: dts: qcom: sa8775p: Fix the size of 'addr_space' regions Manivannan Sadhasivam
2024-11-28 21:58 ` Konrad Dybcio
2024-12-02 15:50 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox