From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>, Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Banajit Goswami <bgoswami@codeaurora.org>,
linux-arm-msm@vger.kernel.org, Patrick Lai <plai@codeaurora.org>,
alsa-devel@alsa-project.org,
V Sujith Kumar Reddy <vsujithk@codeaurora.org>,
Srinivasa Rao <srivasam@codeaurora.org>,
Cheng-Yi Chiang <cychiang@chromium.org>
Subject: Re: [PATCH 0/4] ASoC: qcom: Minor code cleanups for lpass-cpu
Date: Fri, 15 Jan 2021 11:12:42 +0000 [thread overview]
Message-ID: <f60d2cf1-7952-3e85-e988-53e6b91ae75a@linaro.org> (raw)
In-Reply-To: <20210115034327.617223-1-swboyd@chromium.org>
Thanks Stephen for the cleanup patches.
All of them look good to me!
On 15/01/2021 03:43, Stephen Boyd wrote:
> Here's some minor code cleanups for the lpass-cpu driver. I noticed that
> it casts away const from the driver data from DT. That's not great but
> fixing it is a little more involved. I'll get to it later. There's also
> some questionable clk_get() usage that should probably be
> clk_get_optional(). For now this should help a little.
>
> Cc: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> Cc: Srinivasa Rao <srivasam@codeaurora.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Cheng-Yi Chiang <cychiang@chromium.org>
>
> Stephen Boyd (4):
> ASoC: qcom: Remove useless debug print
> ASoC: qcom: Add some names to regmap configs
> ASoC: qcom: Stop casting away __iomem for error pointers
> ASoC: qcom: Remove duplicate error messages on ioremap
>
> sound/soc/qcom/lpass-cpu.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
next prev parent reply other threads:[~2021-01-15 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 3:43 [PATCH 0/4] ASoC: qcom: Minor code cleanups for lpass-cpu Stephen Boyd
2021-01-15 3:43 ` [PATCH 1/4] ASoC: qcom: Remove useless debug print Stephen Boyd
2021-01-15 3:43 ` [PATCH 2/4] ASoC: qcom: Add some names to regmap configs Stephen Boyd
2021-01-15 3:43 ` [PATCH 3/4] ASoC: qcom: Stop casting away __iomem for error pointers Stephen Boyd
2021-01-15 3:43 ` [PATCH 4/4] ASoC: qcom: Remove duplicate error messages on ioremap Stephen Boyd
2021-01-15 11:12 ` Srinivas Kandagatla [this message]
2021-01-15 18:18 ` [PATCH 0/4] ASoC: qcom: Minor code cleanups for lpass-cpu Mark Brown
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f60d2cf1-7952-3e85-e988-53e6b91ae75a@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=srivasam@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=vsujithk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox