[PATCH v2] arm64: dts: qcom: x1e80100: Fix compile warnings for USB HS controller

[PATCH v2] arm64: dts: qcom: x1e80100: Fix compile warnings for USB HS controller

[Krishna Kurapati]

With W=1, the following error comes up:

Warning (graph_child_address): /soc@0/usb@a2f8800/usb@a200000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary

This could be since the controller is only HS capable and only one port
node is added.

Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
Note:
This patch has only been compile tested.

Link to v1:
https://lore.kernel.org/all/20251014022121.1850871-3-krishna.kurapati@oss.qualcomm.com/

Changes in v2:
In v1, the fix was done after flattening the USB controller nodes [1].
Since there is a system suspend issue reported on that patch, the
flattening patch will be sent later after its fixed. For now, sending the
fix for the compile warning.

 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 51576d9c935d..6beef835c33a 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -4939,15 +4939,8 @@ usb_2_dwc3: usb@a200000 {
 
 				dma-coherent;
 
-				ports {
-					#address-cells = <1>;
-					#size-cells = <0>;
-
-					port@0 {
-						reg = <0>;
-
-						usb_2_dwc3_hs: endpoint {
-						};
+				port {
+					usb_2_dwc3_hs: endpoint {
 					};
 				};
 			};
-- 
2.34.1

Re: [PATCH v2] arm64: dts: qcom: x1e80100: Fix compile warnings for USB HS controller

[Dmitry Baryshkov]

On Sun, Oct 19, 2025 at 05:26:30PM +0530, Krishna Kurapati wrote:
> With W=1, the following error comes up:
> 
> Warning (graph_child_address): /soc@0/usb@a2f8800/usb@a200000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> 
> This could be since the controller is only HS capable and only one port
> node is added.
> 
> Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
> Note:
> This patch has only been compile tested.
> 
> Link to v1:
> https://lore.kernel.org/all/20251014022121.1850871-3-krishna.kurapati@oss.qualcomm.com/
> 
> Changes in v2:
> In v1, the fix was done after flattening the USB controller nodes [1].
> Since there is a system suspend issue reported on that patch, the
> flattening patch will be sent later after its fixed. For now, sending the
> fix for the compile warning.
> 
>  arch/arm64/boot/dts/qcom/x1e80100.dtsi | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH v2] arm64: dts: qcom: x1e80100: Fix compile warnings for USB HS controller

[Konrad Dybcio]

On 10/19/25 1:56 PM, Krishna Kurapati wrote:
> With W=1, the following error comes up:
> 
> Warning (graph_child_address): /soc@0/usb@a2f8800/usb@a200000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> 
> This could be since the controller is only HS capable and only one port
> node is added.
> 
> Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v2] arm64: dts: qcom: x1e80100: Fix compile warnings for USB HS controller

[Bjorn Andersson]

On Sun, 19 Oct 2025 17:26:30 +0530, Krishna Kurapati wrote:
> With W=1, the following error comes up:
> 
> Warning (graph_child_address): /soc@0/usb@a2f8800/usb@a200000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> 
> This could be since the controller is only HS capable and only one port
> node is added.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: x1e80100: Fix compile warnings for USB HS controller
      commit: 0dab10c38282e6ef87ef88efb99d4106cce7ed33

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>