[PATCH 0/2] arm64: qcom: apq8096-db820c: enable MSS support

[PATCH 0/2] arm64: qcom: apq8096-db820c: enable MSS support

[Dmitry Baryshkov]

This patchset depends on [1]. After some trial and error and after
enabling QCOM_RMTFS_MEM (mea culpa, it probably was not enabled back in
November, when I was testing these patches), the modem stopped crashing.

The MSS boots fine on DB820c, registers services, etc.

[1]: https://patchwork.kernel.org/project/linux-arm-msm/list/?series=553085&state=%2A&archive=both

Dmitry Baryshkov (2):
  remoteproc: qcom: q6v5-mss: add powerdomains to MSM8996 config
  arm64: dts: qcom: apq8096-db820c: enable MSS node

 arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 6 ++++++
 drivers/remoteproc/qcom_q6v5_mss.c          | 5 +++++
 2 files changed, 11 insertions(+)


base-commit: f443e374ae131c168a065ea1748feac6b2e76613
prerequisite-patch-id: cb78922831b08e04445919773f35c27c1842c7ed
prerequisite-patch-id: be27f629f9ac70529a170399ea8c2a01c1f48913
prerequisite-patch-id: f248d2296b3c450db3db46ecaa4568d2f5296dce
prerequisite-patch-id: c3d6a03b9e5e058caa50ce3c916800c594b76248
-- 
2.35.1

[PATCH 1/2] remoteproc: qcom: q6v5-mss: add powerdomains to MSM8996 config

[Dmitry Baryshkov]

MSM8996 follows the rest of MSS devices and requires a vote on MX and CX
power domains. Add corresponding entry to the device data.

Fixes: 4760a896be88 ("remoteproc: q6v5-mss: Vote for rpmh power domains")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/remoteproc/qcom_q6v5_mss.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
index 43ea8455546c..3b391a196fb4 100644
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -2176,6 +2176,11 @@ static const struct rproc_hexagon_res msm8996_mss = {
 			"mnoc_axi",
 			NULL
 	},
+	.proxy_pd_names = (char*[]){
+			"mx",
+			"cx",
+			NULL
+	},
 	.need_mem_protection = true,
 	.has_alt_reset = false,
 	.has_mba_logs = false,
-- 
2.35.1

Re: [PATCH 1/2] remoteproc: qcom: q6v5-mss: add powerdomains to MSM8996 config

[Dmitry Baryshkov]

On 03/04/2022 22:39, Dmitry Baryshkov wrote:
> MSM8996 follows the rest of MSS devices and requires a vote on MX and CX
> power domains. Add corresponding entry to the device data.
> 
> Fixes: 4760a896be88 ("remoteproc: q6v5-mss: Vote for rpmh power domains")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Gracious ping, this patch doesn't seem to be applied in 5.19-rc1. Can it 
be picked for 5.20?

> ---
>   drivers/remoteproc/qcom_q6v5_mss.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index 43ea8455546c..3b391a196fb4 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -2176,6 +2176,11 @@ static const struct rproc_hexagon_res msm8996_mss = {
>   			"mnoc_axi",
>   			NULL
>   	},
> +	.proxy_pd_names = (char*[]){
> +			"mx",
> +			"cx",
> +			NULL
> +	},
>   	.need_mem_protection = true,
>   	.has_alt_reset = false,
>   	.has_mba_logs = false,


-- 
With best wishes
Dmitry

[PATCH 2/2] arm64: dts: qcom: apq8096-db820c: enable MSS node

[Dmitry Baryshkov]

APQ8096 provides a 'modem' with reduced functionality, mainly targeting
location services. Enable corresponding device tree node.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
index f623db8451f1..56e54ce4d10e 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
@@ -258,6 +258,12 @@ &mmcc {
 	vdd-gfx-supply = <&vdd_gfx>;
 };
 
+&mss_pil {
+	status = "okay";
+	pll-supply = <&vreg_l12a_1p8>;
+	firmware-name = "qcom/apq8096/mba.mbn", "qcom/apq8096/modem.mbn";
+};
+
 &pm8994_resin {
 	status = "okay";
 	linux,code = <KEY_VOLUMEDOWN>;
-- 
2.35.1