Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sricharan Ramabadhran <quic_srichara@quicinc.com>
Cc: jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	andersson@kernel.org, konradybcio@kernel.org,
	manivannan.sadhasivam@linaro.org
Subject: Re: [PATCH V3 2/2] mailbox: tmelite-qmp: Introduce TMEL QMP mailbox driver
Date: Tue, 4 Mar 2025 17:46:19 +0100	[thread overview]
Message-ID: <f8efc961-2fbe-496b-93d2-55f9072bd08c@oss.qualcomm.com> (raw)
In-Reply-To: <CAA8EJppXHXafwx+GPh0UhFLRLW5DNj8RwXdO4+fDdXp=SE13Uw@mail.gmail.com>

On 4.03.2025 10:46 AM, Dmitry Baryshkov wrote:
> On Tue, 4 Mar 2025 at 10:33, Sricharan Ramabadhran
> <quic_srichara@quicinc.com> wrote:
>>
>>
>>
>> On 3/3/2025 6:34 PM, Dmitry Baryshkov wrote:
>>> On Mon, Mar 03, 2025 at 03:58:42PM +0530, Sricharan Ramabadhran wrote:
>>>>
>>>>
>>>> On 2/28/2025 12:03 PM, Dmitry Baryshkov wrote:
>>>>> On Fri, Feb 28, 2025 at 10:23:56AM +0530, Sricharan R wrote:
>>>
>>>>>> +          dev_err(dev, "Failed with status: %d\n", msg.resp.status);
>>>>>> +          ret = msg.resp.status;
>>>>>
>>>>> return msg.resp.status (is it really errno?)
>>>>>
>>>> ok, yes error.
>>>
>>> The question was if it is an errno, not if it is an error.
>> status != 0 is an error always.
> 
> Is it an _errno_ ?

Dmitry's asking whether the status conforms to the Linux's errno.h
ABI. If not, add something like:

ret = msg.resp.status ? -EINVAL : 0

Konrad

  reply	other threads:[~2025-03-04 16:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28  4:53 [PATCH V3 0/2] mailbox: tmel-qmp: Introduce QCOM TMEL QMP mailbox driver Sricharan R
2025-02-28  4:53 ` [PATCH V3 1/2] dt-bindings: mailbox: Document qcom,tmel-qmp Sricharan R
2025-02-28  6:06   ` Dmitry Baryshkov
2025-03-03  7:21     ` Sricharan Ramabadhran
2025-03-03 13:03       ` Dmitry Baryshkov
2025-03-04  8:57         ` Sricharan Ramabadhran
2025-02-28  4:53 ` [PATCH V3 2/2] mailbox: tmelite-qmp: Introduce TMEL QMP mailbox driver Sricharan R
2025-02-28  6:33   ` Dmitry Baryshkov
2025-03-03 10:28     ` Sricharan Ramabadhran
2025-03-03 13:04       ` Dmitry Baryshkov
2025-03-04  9:33         ` Sricharan Ramabadhran
2025-03-04  9:46           ` Dmitry Baryshkov
2025-03-04 16:46             ` Konrad Dybcio [this message]
2025-03-05  7:33               ` Sricharan Ramabadhran
2025-03-05  6:12             ` Sricharan Ramabadhran
2025-03-06  0:26   ` kernel test robot
2025-03-06  7:53   ` kernel test robot
2025-03-06 17:49   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8efc961-2fbe-496b-93d2-55f9072bd08c@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=quic_srichara@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox