From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: MarshallZhan-wiwynn <marshall_zhan@wiwynn.com>, patrick@stwcx.xyz
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH dev 6.6 v3] ARM: dts: aspeed: yosemite4: add I3C config in DTS
Date: Mon, 17 Feb 2025 11:31:23 +1030 [thread overview]
Message-ID: <047ea26fbb5713e852431d0731e21d34af39e1c2.camel@codeconstruct.com.au> (raw)
In-Reply-To: <24d2d411365004f11498777501da54d6a9c6e758.camel@codeconstruct.com.au>
On Mon, 2025-02-17 at 11:14 +1030, Andrew Jeffery wrote:
> Hi Marshall,
>
> On Fri, 2025-02-14 at 09:15 +0800, MarshallZhan-wiwynn wrote:
> > Set I3C config in yosemite4 DTS.
> >
> > Test plan:
> > Tested pass with aspeed I3C patches and I3C hub driver.
>
> Can you please expand the commit message to provide details? This
> statement is quite vague, and I don't find it terribly helpful as it
> stands. Which aspeed patches? What tests?
Also, you've sent this patch to the upstream lists and maintainers, but
it appears you're intending this to be applied to the OpenBMC kernel
fork. Please understand the difference between the two and review my
recent response to Rush Chen:
https://lore.kernel.org/all/9f0447151e6574d74e7fa9cbbb50d8e970059273.camel@codeconstruct.com.au/
Beyond that, for patches to be backported into the OpenBMC fork they
should first be merged upstream, in which case they must be tested
against a recent upstream tag (e.g. v6.14-r3) before they are sent. It
will be worth reviewing the following:
https://docs.kernel.org/process/development-process.html
The "Submitting Patches" documentation provides a more succinct
treatment:
https://docs.kernel.org/process/submitting-patches.html
If you have any questions, please feel free to contact myself or Joel
off-list.
Andrew
prev parent reply other threads:[~2025-02-17 1:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 1:15 [PATCH dev 6.6 v3] ARM: dts: aspeed: yosemite4: add I3C config in DTS MarshallZhan-wiwynn
2025-02-17 0:44 ` Andrew Jeffery
2025-02-17 1:01 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=047ea26fbb5713e852431d0731e21d34af39e1c2.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marshall_zhan@wiwynn.com \
--cc=patrick@stwcx.xyz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox