Re: [PATCH dev 6.6 v3] ARM: dts: aspeed: yosemite4: add I3C config in DTS

[Andrew Jeffery <andrew@codeconstruct.com.au>]

Hi Marshall,

On Fri, 2025-02-14 at 09:15 +0800, MarshallZhan-wiwynn wrote:
> Set I3C config in yosemite4 DTS.
> 
> Test plan:
> Tested pass with aspeed I3C patches and I3C hub driver.

Can you please expand the commit message to provide details? This
statement is quite vague, and I don't find it terribly helpful as it
stands. Which aspeed patches? What tests?

> 
> Signed-off-by: MarshallZhan-wiwynn <marshall_zhan@wiwynn.com>
> ---
>  .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 88
> +++++++++++++++++++
>  1 file changed, 88 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-
> yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-
> yosemite4.dts
> index ab4904cf2c0e..3f98e67674d0 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -1317,6 +1317,94 @@ eeprom@50 {
>         };
>  };
> 
> 
...
>  &adc0 {
>         status = "okay";
>         pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
> --
> 2.25.1
> 
> WIWYNN PROPRIETARY
> This email (and any attachments) contains proprietary or confidential
> information and is for the sole use of its intended recipient. Any
> unauthorized review, use, copying or distribution of this email or
> the content of this email is strictly prohibited. If you are not the
> intended recipient, please notify the sender and delete this email
> immediately.

Please avoid including these confidentiality clauses:

https://subspace.kernel.org/etiquette.html#do-not-include-confidentiality-disclaimers

Andrew