public inbox for linux-aspeed@lists.ozlabs.org
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@aj.id.au>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2 0/4] watchdog: aspeed: Retain enabled state and move to arch_initcall
Date: Wed, 20 Sep 2017 15:00:16 +0930	[thread overview]
Message-ID: <20170920053020.6860-1-andrew@aj.id.au> (raw)

Hello,

This series fixes some issues with the Aspeed watchdog, as outlined in the
v1[1] cover letter.

I've added a bit of an explanation as to why we call aspeed_wdt_start() in
probe() if the watchdog is already enabled, but the essence of it is to ensure
the watchdog is configured to the expectations of the kernel driver (rather
than however the bootloader configured it).

Please review!

Andrew

Since v1:

* Rework patch 1/4 to simply remove the writel() call to restore the original
  behaviour.
* Rework patch 4/4 to remove the Kconfig changes to retain the ability to build
  the watchdog as a module, and add the exit handler.

[1] https://lkml.org/lkml/2017/9/18/14

Andrew Jeffery (4):
  watchdog: aspeed: Retain watchdog enabled state
  watchdog: aspeed: Fix 'Apseed' typo in Kconfig
  watchdog: aspeed: Remove specific reference to AST2400 in Kconfig
  watchdog: aspeed: Move init to arch_initcall

 drivers/watchdog/Kconfig      |  4 ++--
 drivers/watchdog/aspeed_wdt.c | 21 ++++++++++++++++++---
 2 files changed, 20 insertions(+), 5 deletions(-)

-- 
2.11.0


             reply	other threads:[~2017-09-20  5:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20  5:30 Andrew Jeffery [this message]
2017-09-20  5:30 ` [PATCH v2 1/4] watchdog: aspeed: Retain watchdog enabled state Andrew Jeffery
2017-09-20  6:07   ` Joel Stanley
2017-10-22 16:09   ` [v2,1/4] " Guenter Roeck
2017-09-20  5:30 ` [PATCH v2 2/4] watchdog: aspeed: Fix 'Apseed' typo in Kconfig Andrew Jeffery
2017-09-20  6:07   ` Joel Stanley
2017-09-20  5:30 ` [PATCH v2 3/4] watchdog: aspeed: Remove specific reference to AST2400 " Andrew Jeffery
2017-09-20  6:08   ` Joel Stanley
2017-09-20  5:30 ` [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall Andrew Jeffery
2017-09-20  6:13   ` Joel Stanley
2017-10-17 11:35     ` Andrew Jeffery
2017-10-22 16:22       ` Guenter Roeck
2017-10-22 16:13   ` [v2,4/4] " Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170920053020.6860-1-andrew@aj.id.au \
    --to=andrew@aj.id.au \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox