From: Guenter Roeck <linux@roeck-us.net>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall
Date: Sun, 22 Oct 2017 09:22:05 -0700 [thread overview]
Message-ID: <c3f1b8d1-fe4d-c68f-5f05-c4cb75912e2c@roeck-us.net> (raw)
In-Reply-To: <1508240158.24322.16.camel@aj.id.au>
On 10/17/2017 04:35 AM, Andrew Jeffery wrote:
> On Wed, 2017-09-20 at 15:43 +0930, Joel Stanley wrote:
>>> On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
>>> Probing at device_initcall time lead to perverse cases where the
>>> watchdog was probed after, say, I2C devices, which then leaves a
>>> potentially running watchdog at the mercy of I2C device behaviour and
>>> bus conditions.
>>>
>>> Load the watchdog driver early to ensure that the kernel is patting it
>>> well before initialising peripherals.
>>>
>>> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
>>
>> I agree that we need to make sure the watchdog driver is loaded
>> earlier. I think this is the correct method, but I'll defer to Guenter
>> on this one.
>
> Just following up on Joel's comments: Is there anything else I need to
> address?
>
No. Sorry, I have been terribly busy. Digging through patch backlog today.
Guenter
next prev parent reply other threads:[~2017-10-22 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 5:30 [PATCH v2 0/4] watchdog: aspeed: Retain enabled state and move to arch_initcall Andrew Jeffery
2017-09-20 5:30 ` [PATCH v2 1/4] watchdog: aspeed: Retain watchdog enabled state Andrew Jeffery
2017-09-20 6:07 ` Joel Stanley
2017-10-22 16:09 ` [v2,1/4] " Guenter Roeck
2017-09-20 5:30 ` [PATCH v2 2/4] watchdog: aspeed: Fix 'Apseed' typo in Kconfig Andrew Jeffery
2017-09-20 6:07 ` Joel Stanley
2017-09-20 5:30 ` [PATCH v2 3/4] watchdog: aspeed: Remove specific reference to AST2400 " Andrew Jeffery
2017-09-20 6:08 ` Joel Stanley
2017-09-20 5:30 ` [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall Andrew Jeffery
2017-09-20 6:13 ` Joel Stanley
2017-10-17 11:35 ` Andrew Jeffery
2017-10-22 16:22 ` Guenter Roeck [this message]
2017-10-22 16:13 ` [v2,4/4] " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3f1b8d1-fe4d-c68f-5f05-c4cb75912e2c@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox