From: Wolfram Sang <wsa@the-dreams.de>
To: linux-aspeed@lists.ozlabs.org
Subject: AST2600 i2c irq issue
Date: Mon, 21 Oct 2019 14:16:29 +0200 [thread overview]
Message-ID: <20191021121629.GE1145@ninjato> (raw)
In-Reply-To: <8c62b118777c44d1bf8e1a3c32175644@TWMBX02.aspeed.com>
> spin_lock(&bus->lock);
> irq_received = readl(bus->base + ASPEED_I2C_INTR_STS_REG);
> + if (!irq_received)
> + return IRQ_NONE;
> +
> /* Ack all interrupts except for Rx done */
> writel(irq_received & ~ASPEED_I2CD_INTR_RX_DONE,
> bus->base + ASPEED_I2C_INTR_STS_REG);
>
>
> I think it's a right fix for the issue. At least, we need to prevent
> any driver state corruption. The state machine would run correctly if
> we filtering the garbage interrupt out.
Just unlock the spinlock before you return...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20191021/eeb5c44a/attachment.sig>
next prev parent reply other threads:[~2019-10-21 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 6:14 AST2600 i2c irq issue Joel Stanley
2019-10-17 20:31 ` Eddie James
2019-10-17 22:29 ` Jae Hyun Yoo
2019-10-18 4:28 ` Peter Rosin
2019-10-18 16:07 ` Jae Hyun Yoo
2019-10-19 1:36 ` Ryan Chen
2019-10-21 12:16 ` Wolfram Sang [this message]
2019-10-21 18:27 ` Jae Hyun Yoo
2019-10-22 20:24 ` Eddie James
2019-10-24 18:03 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021121629.GE1145@ninjato \
--to=wsa@the-dreams.de \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox