Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
To: linux-aspeed@lists.ozlabs.org
Subject: AST2600 i2c irq issue
Date: Mon, 21 Oct 2019 11:27:23 -0700	[thread overview]
Message-ID: <cdc01cea-57a3-3b54-e3a1-44088c9120ed@linux.intel.com> (raw)
In-Reply-To: <20191021121629.GE1145@ninjato>

On 10/21/2019 5:16 AM, Wolfram Sang wrote:
> 
>>           spin_lock(&bus->lock);
>>           irq_received = readl(bus->base + ASPEED_I2C_INTR_STS_REG);
>> +       if (!irq_received)
>> +               return IRQ_NONE;
>> +
>>           /* Ack all interrupts except for Rx done */
>>           writel(irq_received & ~ASPEED_I2CD_INTR_RX_DONE,
>>                  bus->base + ASPEED_I2C_INTR_STS_REG);
>>
>>
>> I think it's a right fix for the issue. At least, we need to prevent
>> any driver state corruption. The state machine would run correctly if
>> we filtering the garbage interrupt out.
> 
> Just unlock the spinlock before you return...

Thanks Wolfram!

Peter also pointed it out, and Eddie made a patch which includes the
spin_unlock.

Hi Eddie,
Can you please submit your patch into 'i2c-next' upstream?

Thanks,

Jae

  reply	other threads:[~2019-10-21 18:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-17  6:14 AST2600 i2c irq issue Joel Stanley
2019-10-17 20:31 ` Eddie James
2019-10-17 22:29   ` Jae Hyun Yoo
2019-10-18  4:28     ` Peter Rosin
2019-10-18 16:07       ` Jae Hyun Yoo
2019-10-19  1:36     ` Ryan Chen
2019-10-21 12:16       ` Wolfram Sang
2019-10-21 18:27         ` Jae Hyun Yoo [this message]
2019-10-22 20:24       ` Eddie James
2019-10-24 18:03         ` Jae Hyun Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdc01cea-57a3-3b54-e3a1-44088c9120ed@linux.intel.com \
    --to=jae.hyun.yoo@linux.intel.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox