* [PATCH v1 1/2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC @ 2022-10-06 6:35 Delphine CC Chiu 2022-10-06 6:35 ` [PATCH v1 2/2] " Delphine CC Chiu 2022-10-06 7:06 ` [PATCH v1 1/2] " Krzysztof Kozlowski 0 siblings, 2 replies; 4+ messages in thread From: Delphine CC Chiu @ 2022-10-06 6:35 UTC (permalink / raw) To: linux-aspeed Document the new compatibles used on Facebook Greatlakes Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 1895ce9de461..f12b94ddb9ec 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -75,6 +75,7 @@ properties: - facebook,cloudripper-bmc - facebook,elbert-bmc - facebook,fuji-bmc + - facebook,greatlakes-bmc - ibm,everest-bmc - ibm,rainier-bmc - ibm,tacoma-bmc -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1 2/2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC 2022-10-06 6:35 [PATCH v1 1/2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC Delphine CC Chiu @ 2022-10-06 6:35 ` Delphine CC Chiu 2022-10-06 7:10 ` Krzysztof Kozlowski 2022-10-06 7:06 ` [PATCH v1 1/2] " Krzysztof Kozlowski 1 sibling, 1 reply; 4+ messages in thread From: Delphine CC Chiu @ 2022-10-06 6:35 UTC (permalink / raw) To: linux-aspeed Add linux device tree entry related to greatlakes specific devices connected to BMC SoC. --- --- v1 - Add documentation of board compatible (bindings) --- - Add board compatible --- - Remove the bootargs --- - Revise the DTS node name --- Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> --- arch/arm/boot/dts/Makefile | 1 + .../dts/aspeed-bmc-facebook-greatlakes.dts | 243 ++++++++++++++++++ 2 files changed, 244 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 05d8aef6e5d2..d9f417f2d7df 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -1586,6 +1586,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-elbert.dtb \ aspeed-bmc-facebook-fuji.dtb \ aspeed-bmc-facebook-galaxy100.dtb \ + aspeed-bmc-facebook-greatlakes.dtb \ aspeed-bmc-facebook-minipack.dtb \ aspeed-bmc-facebook-tiogapass.dtb \ aspeed-bmc-facebook-wedge40.dtb \ diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts new file mode 100644 index 000000000000..29c46d0e003e --- /dev/null +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts @@ -0,0 +1,243 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +// Copyright 2022 Facebook Inc. + +/dts-v1/; +#include "aspeed-g6.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> +#include <dt-bindings/leds/leds-pca955x.h> +#include <dt-bindings/i2c/i2c.h> + +/ { + model = "Facebook Greatlakes BMC"; + compatible = "facebook,greatlakes-bmc", "aspeed,ast2600"; + + aliases { + serial4 = &uart5; + }; + + memory at 80000000 { + device_type = "memory"; + reg = <0x80000000 0x80000000>; + }; + + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>, + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>, + <&adc1 0>, <&adc1 2>, <&adc1 3>, <&adc1 4>, + <&adc1 5>, <&adc1 6>; + }; +}; + +&uart1 { + status = "okay"; +}; + +&uart2 { + status = "okay"; +}; + +&uart3 { + status = "okay"; +}; + +&uart4 { + status = "okay"; +}; + +&uart5 { + status = "okay"; +}; + +&wdt1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_wdtrst1_default>; + aspeed,reset-type = "soc"; + aspeed,external-signal; + aspeed,ext-push-pull; + aspeed,ext-active-high; + aspeed,ext-pulse-duration = <256>; +}; + +&mac3 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii4_default>; + no-hw-checksum; + use-ncsi; + mlx,multi-host; + ncsi-ctrl,start-redo-probe; + ncsi-ctrl,no-channel-monitor; + ncsi-package = <1>; + ncsi-channel = <1>; + ncsi-rexmit = <1>; + ncsi-timeout = <2>; +}; + +&rtc { + status = "okay"; +}; + +&fmc { + status = "okay"; + flash at 0 { + status = "okay"; + m25p,fast-read; + label = "bmc"; + spi-rx-bus-width = <4>; + spi-max-frequency = <50000000>; +#include "openbmc-flash-layout-64.dtsi" + }; + flash at 1 { + status = "okay"; + m25p,fast-read; + label = "bmc2"; + spi-rx-bus-width = <4>; + spi-max-frequency = <50000000>; + }; +}; + +&i2c0 { + status = "okay"; + multi-master; + ipmb0 at 10 { + compatible = "ipmb-dev"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + i2c-protocol; + }; +}; + +&i2c1 { + status = "okay"; + multi-master; + ipmb1 at 10 { + compatible = "ipmb-dev"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + i2c-protocol; + }; +}; + +&i2c2 { + status = "okay"; + multi-master; + ipmb2 at 10 { + compatible = "ipmb-dev"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + i2c-protocol; + }; +}; + +&i2c3 { + status = "okay"; + multi-master; + ipmb3 at 10 { + compatible = "ipmb-dev"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + i2c-protocol; + }; +}; + +&i2c4 { + status = "okay"; +}; + +&i2c5 { + status = "okay"; +}; + +&i2c6 { + status = "okay"; +}; + +&i2c7 { + status = "okay"; +}; + +&i2c8 { + status = "okay"; + temperature-sensor at 1f { + compatible = "ti,tmp421"; + reg = <0x1f>; + }; + // NIC EEPROM + eeprom at 50 { + compatible = "st,24c32"; + reg = <0x50>; + }; +}; + +&i2c9 { + status = "okay"; + multi-master; + ipmb9 at 10 { + compatible = "ipmb-dev"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + i2c-protocol; + }; +}; + +&i2c10 { + status = "okay"; +}; + +&i2c11 { + status = "okay"; + eeprom at 51 { + compatible = "atmel,24c128"; + reg = <0x51>; + }; + eeprom at 54 { + compatible = "atmel,24c128"; + reg = <0x54>; + }; +}; + +&i2c12 { + status = "okay"; + temperature-sensor at 4f { + compatible = "lm75"; + reg = <0x4f>; + }; +}; + +&i2c13 { + status = "okay"; +}; + +&adc0 { + ref_voltage = <2500>; + status = "okay"; + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default + &pinctrl_adc2_default &pinctrl_adc3_default + &pinctrl_adc4_default &pinctrl_adc5_default + &pinctrl_adc6_default &pinctrl_adc7_default>; +}; + +&adc1 { + ref_voltage = <2500>; + status = "okay"; + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc10_default + &pinctrl_adc11_default &pinctrl_adc12_default + &pinctrl_adc13_default &pinctrl_adc14_default>; +}; + + +&ehci0 { + status = "okay"; +}; + +&ehci1 { + status = "okay"; +}; + +&uhci { + status = "okay"; +}; + +&gpio0 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_gpiu1_default &pinctrl_gpiu7_default>; +}; + + -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1 2/2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC 2022-10-06 6:35 ` [PATCH v1 2/2] " Delphine CC Chiu @ 2022-10-06 7:10 ` Krzysztof Kozlowski 0 siblings, 0 replies; 4+ messages in thread From: Krzysztof Kozlowski @ 2022-10-06 7:10 UTC (permalink / raw) To: linux-aspeed On 06/10/2022 08:35, Delphine CC Chiu wrote: > Add linux device tree entry related to > greatlakes specific devices connected to BMC SoC. > > --- > --- v1 - Add documentation of board compatible (bindings) > --- - Add board compatible > --- - Remove the bootargs > --- - Revise the DTS node name > --- This is v3, not v1, because you resent first patch twice Changelog does not go above SoB. You can see the problem easily - save your patch, git am xxx.mbox, git show Subject is wrong. Use subject prefixes matching the subsystem (git log --oneline -- ...). > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > --- > arch/arm/boot/dts/Makefile | 1 + > .../dts/aspeed-bmc-facebook-greatlakes.dts | 243 ++++++++++++++++++ > 2 files changed, 244 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 05d8aef6e5d2..d9f417f2d7df 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1586,6 +1586,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-facebook-elbert.dtb \ > aspeed-bmc-facebook-fuji.dtb \ > aspeed-bmc-facebook-galaxy100.dtb \ > + aspeed-bmc-facebook-greatlakes.dtb \ > aspeed-bmc-facebook-minipack.dtb \ > aspeed-bmc-facebook-tiogapass.dtb \ > aspeed-bmc-facebook-wedge40.dtb \ > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts > new file mode 100644 > index 000000000000..29c46d0e003e > --- /dev/null > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts > @@ -0,0 +1,243 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +// Copyright 2022 Facebook Inc. > + > +/dts-v1/; > +#include "aspeed-g6.dtsi" > +#include <dt-bindings/gpio/aspeed-gpio.h> > +#include <dt-bindings/leds/leds-pca955x.h> > +#include <dt-bindings/i2c/i2c.h> > + > +/ { > + model = "Facebook Greatlakes BMC"; > + compatible = "facebook,greatlakes-bmc", "aspeed,ast2600"; > + > + aliases { > + serial4 = &uart5; > + }; > + > + memory at 80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x80000000>; > + }; > + > + iio-hwmon { > + compatible = "iio-hwmon"; > + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>, > + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>, > + <&adc1 0>, <&adc1 2>, <&adc1 3>, <&adc1 4>, > + <&adc1 5>, <&adc1 6>; > + }; > +}; > + > +&uart1 { > + status = "okay"; > +}; > + > +&uart2 { > + status = "okay"; > +}; > + > +&uart3 { > + status = "okay"; > +}; > + > +&uart4 { > + status = "okay"; > +}; > + > +&uart5 { > + status = "okay"; > +}; > + > +&wdt1 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdtrst1_default>; > + aspeed,reset-type = "soc"; > + aspeed,external-signal; > + aspeed,ext-push-pull; > + aspeed,ext-active-high; > + aspeed,ext-pulse-duration = <256>; > +}; > + > +&mac3 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rmii4_default>; > + no-hw-checksum; > + use-ncsi; > + mlx,multi-host; > + ncsi-ctrl,start-redo-probe; > + ncsi-ctrl,no-channel-monitor; > + ncsi-package = <1>; > + ncsi-channel = <1>; > + ncsi-rexmit = <1>; > + ncsi-timeout = <2>; > +}; > + > +&rtc { > + status = "okay"; > +}; > + > +&fmc { > + status = "okay"; > + flash at 0 { > + status = "okay"; > + m25p,fast-read; > + label = "bmc"; > + spi-rx-bus-width = <4>; > + spi-max-frequency = <50000000>; > +#include "openbmc-flash-layout-64.dtsi" > + }; > + flash at 1 { > + status = "okay"; > + m25p,fast-read; > + label = "bmc2"; > + spi-rx-bus-width = <4>; > + spi-max-frequency = <50000000>; > + }; > +}; > + > +&i2c0 { > + status = "okay"; > + multi-master; > + ipmb0 at 10 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Therefore: ipmb at 10 > + compatible = "ipmb-dev"; > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; > + i2c-protocol; > + }; > +}; > + > +&i2c1 { > + status = "okay"; > + multi-master; > + ipmb1 at 10 { ipmb at 10 > + compatible = "ipmb-dev"; > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; > + i2c-protocol; > + }; > +}; > + > +&i2c2 { > + status = "okay"; > + multi-master; > + ipmb2 at 10 { ipmb at 10 > + compatible = "ipmb-dev"; > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; > + i2c-protocol; > + }; > +}; > + > +&i2c3 { > + status = "okay"; > + multi-master; > + ipmb3 at 10 { ipmb at 10 > + compatible = "ipmb-dev"; > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; > + i2c-protocol; > + }; > +}; > + > +&i2c4 { > + status = "okay"; > +}; > + > +&i2c5 { > + status = "okay"; > +}; > + > +&i2c6 { > + status = "okay"; > +}; > + > +&i2c7 { > + status = "okay"; > +}; > + > +&i2c8 { > + status = "okay"; > + temperature-sensor at 1f { > + compatible = "ti,tmp421"; > + reg = <0x1f>; > + }; > + // NIC EEPROM > + eeprom at 50 { > + compatible = "st,24c32"; > + reg = <0x50>; > + }; > +}; > + > +&i2c9 { > + status = "okay"; > + multi-master; > + ipmb9 at 10 { ipmb at 10 > + compatible = "ipmb-dev"; > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; > + i2c-protocol; > + }; > +}; > + > +&i2c10 { > + status = "okay"; > +}; > + > +&i2c11 { > + status = "okay"; > + eeprom at 51 { > + compatible = "atmel,24c128"; > + reg = <0x51>; > + }; > + eeprom at 54 { > + compatible = "atmel,24c128"; > + reg = <0x54>; > + }; > +}; > + > +&i2c12 { > + status = "okay"; > + temperature-sensor at 4f { > + compatible = "lm75"; > + reg = <0x4f>; > + }; > +}; > + > +&i2c13 { > + status = "okay"; > +}; > + > +&adc0 { > + ref_voltage = <2500>; > + status = "okay"; > + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default > + &pinctrl_adc2_default &pinctrl_adc3_default > + &pinctrl_adc4_default &pinctrl_adc5_default > + &pinctrl_adc6_default &pinctrl_adc7_default>; > +}; > + > +&adc1 { > + ref_voltage = <2500>; > + status = "okay"; > + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc10_default > + &pinctrl_adc11_default &pinctrl_adc12_default > + &pinctrl_adc13_default &pinctrl_adc14_default>; > +}; > + > + > +&ehci0 { > + status = "okay"; > +}; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&uhci { > + status = "okay"; > +}; > + > +&gpio0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpiu1_default &pinctrl_gpiu7_default>; > +}; > + > + No need for two blank lines at the end. Drop both. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC 2022-10-06 6:35 [PATCH v1 1/2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC Delphine CC Chiu 2022-10-06 6:35 ` [PATCH v1 2/2] " Delphine CC Chiu @ 2022-10-06 7:06 ` Krzysztof Kozlowski 1 sibling, 0 replies; 4+ messages in thread From: Krzysztof Kozlowski @ 2022-10-06 7:06 UTC (permalink / raw) To: linux-aspeed On 06/10/2022 08:35, Delphine CC Chiu wrote: > Document the new compatibles used on Facebook Greatlakes > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > --- This is v2, not v1. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-06 7:10 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-10-06 6:35 [PATCH v1 1/2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC Delphine CC Chiu 2022-10-06 6:35 ` [PATCH v1 2/2] " Delphine CC Chiu 2022-10-06 7:10 ` Krzysztof Kozlowski 2022-10-06 7:06 ` [PATCH v1 1/2] " Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox