From: Lei Liu <liulei.rjpt@vivo.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v1 1/5] usb: aspeed_udc: Use devm_clk_get_enabled() helpers
Date: Thu, 22 Aug 2024 12:07:26 +0800 [thread overview]
Message-ID: <20240822040734.29412-2-liulei.rjpt@vivo.com> (raw)
In-Reply-To: <20240822040734.29412-1-liulei.rjpt@vivo.com>
The devm_clk_get_enabled() helpers:
- call devm_clk_get()
- call clk_prepare_enable() and register what is needed in order to
call clk_disable_unprepare() when needed, as a managed resource.
This simplifies the code and avoids calls to clk_disable_unprepare().
Signed-off-by: Lei Liu <liulei.rjpt@vivo.com>
---
drivers/usb/gadget/udc/aspeed_udc.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index f4781e611aaa..a362e31f7550 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1459,8 +1459,6 @@ static void ast_udc_remove(struct platform_device *pdev)
ctrl = ast_udc_read(udc, AST_UDC_FUNC_CTRL) & ~USB_UPSTREAM_EN;
ast_udc_write(udc, ctrl, AST_UDC_FUNC_CTRL);
- clk_disable_unprepare(udc->clk);
-
spin_unlock_irqrestore(&udc->lock, flags);
if (udc->ep0_buf)
@@ -1500,16 +1498,11 @@ static int ast_udc_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, udc);
- udc->clk = devm_clk_get(&pdev->dev, NULL);
+ udc->clk = devm_clk_get_enabled(&pdev->dev, NULL);
if (IS_ERR(udc->clk)) {
rc = PTR_ERR(udc->clk);
goto err;
}
- rc = clk_prepare_enable(udc->clk);
- if (rc) {
- dev_err(&pdev->dev, "Failed to enable clock (0x%x)\n", rc);
- goto err;
- }
/* Check if we need to limit the HW to USB1 */
max_speed = usb_get_maximum_speed(&pdev->dev);
--
2.34.1
next prev parent reply other threads:[~2024-08-22 4:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 4:07 [PATCH v1 0/5] usb drivers use devm_clk_get_enabled() helpers Lei Liu
2024-08-22 4:07 ` Lei Liu [this message]
2024-08-22 4:07 ` [PATCH v1 2/5] usb: pxa27x_udc: Use " Lei Liu
2024-08-22 4:07 ` [PATCH v1 3/5] usb: r8a66597-udc: " Lei Liu
2024-08-22 4:07 ` [PATCH v1 4/5] usb: mpfs: " Lei Liu
2024-08-22 4:07 ` [PATCH v1 5/5] usb: ux500: " Lei Liu
2024-08-22 4:27 ` [PATCH v1 0/5] usb drivers use " Greg Kroah-Hartman
2024-08-22 4:46 ` Lei Liu
2024-08-22 5:14 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822040734.29412-2-liulei.rjpt@vivo.com \
--to=liulei.rjpt@vivo.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox