Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v1 0/5] usb drivers use devm_clk_get_enabled() helpers
Date: Thu, 22 Aug 2024 13:14:41 +0800	[thread overview]
Message-ID: <2024082227-sports-resource-9c65@gregkh> (raw)
In-Reply-To: <b356bdb2-fc17-44ef-b0e5-3868b452a8c2@vivo.com>

On Thu, Aug 22, 2024 at 12:46:10PM +0800, Lei Liu wrote:
> 
> on 2024/8/22 12:27, Greg Kroah-Hartman wrote:
> > On Thu, Aug 22, 2024 at 12:07:25PM +0800, Lei Liu wrote:
> > > The devm_clk_get_enabled() helpers:
> > >      - call devm_clk_get()
> > >      - call clk_prepare_enable() and register what is needed in order to
> > >       call clk_disable_unprepare() when needed, as a managed resource.
> > > 
> > > This simplifies the code and avoids calls to clk_disable_unprepare().
> > > 
> > > ---
> > > The files ux500.c, mpfs.c, and pxa27x_udc.c have incorrect usage of
> > > certain interfaces due to the lack of synchronization during the
> > > commit updates. These issues have been corrected in the v1 version.
> > > 
> > > version 1 changes
> > > 1.ux500: Incorrect usage of clk_prepare_enable() should be corrected to
> > >    devm_clk_get_enabled().
> > > 2.mpfs: Incorrect usage of devm_clk_get_enable() should be corrected to
> > >    devm_clk_get_enabled().
> > > 3.pxa27x_udc: Incorrect usage of clk_prepare_enable() should be
> > >    corrected to devm_clk_get_enabled().
> > Patch versions start at 1, this should be 2, right?
> 
> Hi?Do I need to update the patch from v1 to v2 again?

Yes please, otherwise our tools will get confused.

greg k-h

      reply	other threads:[~2024-08-22  5:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-22  4:07 [PATCH v1 0/5] usb drivers use devm_clk_get_enabled() helpers Lei Liu
2024-08-22  4:07 ` [PATCH v1 1/5] usb: aspeed_udc: Use " Lei Liu
2024-08-22  4:07 ` [PATCH v1 2/5] usb: pxa27x_udc: " Lei Liu
2024-08-22  4:07 ` [PATCH v1 3/5] usb: r8a66597-udc: " Lei Liu
2024-08-22  4:07 ` [PATCH v1 4/5] usb: mpfs: " Lei Liu
2024-08-22  4:07 ` [PATCH v1 5/5] usb: ux500: " Lei Liu
2024-08-22  4:27 ` [PATCH v1 0/5] usb drivers use " Greg Kroah-Hartman
2024-08-22  4:46   ` Lei Liu
2024-08-22  5:14     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024082227-sports-resource-9c65@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox