Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH dev-5.1] ARM: dts: aspeed: swift: Add VDD (IR35219) devices
@ 2019-05-31 20:31 Adriana Kobylak
  2019-06-03  9:06 ` Joel Stanley
  0 siblings, 1 reply; 4+ messages in thread
From: Adriana Kobylak @ 2019-05-31 20:31 UTC (permalink / raw)
  To: linux-aspeed

From: Adriana Kobylak <anoo@us.ibm.com>

Add the VDD (IR35219) devices to the Swift device tree.

Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
---
 arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
index 270c923..8590e6b 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
@@ -723,6 +723,11 @@
 		reg = <0x4c>;
 	};
 
+	ir35219 at 70 {
+		compatible = "infineon,ir35219";
+		reg = <0x70>;
+	};
+
 	ir35221 at 71 {
 		compatible = "infineon,ir35221";
 		reg = <0x71>;
@@ -820,6 +825,11 @@
 		reg = <0x4c>;
 	};
 
+	ir35219 at 70 {
+		compatible = "infineon,ir35219";
+		reg = <0x70>;
+	};
+
 	ir35221 at 71 {
 		compatible = "infineon,ir35221";
 		reg = <0x71>;
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH dev-5.1] ARM: dts: aspeed: swift: Add VDD (IR35219) devices
  2019-05-31 20:31 [PATCH dev-5.1] ARM: dts: aspeed: swift: Add VDD (IR35219) devices Adriana Kobylak
@ 2019-06-03  9:06 ` Joel Stanley
  2019-06-03 19:38   ` Adriana Kobylak
  0 siblings, 1 reply; 4+ messages in thread
From: Joel Stanley @ 2019-06-03  9:06 UTC (permalink / raw)
  To: linux-aspeed

On Fri, 31 May 2019 at 20:31, Adriana Kobylak <anoo@linux.ibm.com> wrote:
>
> From: Adriana Kobylak <anoo@us.ibm.com>
>
> Add the VDD (IR35219) devices to the Swift device tree.
>
> +       ir35219 at 70 {
> +               compatible = "infineon,ir35219";

There's no driver for these in our tree. Do you have one coming?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH dev-5.1] ARM: dts: aspeed: swift: Add VDD (IR35219) devices
  2019-06-03  9:06 ` Joel Stanley
@ 2019-06-03 19:38   ` Adriana Kobylak
  2019-06-03 23:04     ` Joel Stanley
  0 siblings, 1 reply; 4+ messages in thread
From: Adriana Kobylak @ 2019-06-03 19:38 UTC (permalink / raw)
  To: linux-aspeed

On 2019-06-03 04:06, Joel Stanley wrote:
> On Fri, 31 May 2019 at 20:31, Adriana Kobylak <anoo@linux.ibm.com> 
> wrote:
>> 
>> From: Adriana Kobylak <anoo@us.ibm.com>
>> 
>> Add the VDD (IR35219) devices to the Swift device tree.
>> 
>> +       ir35219 at 70 {
>> +               compatible = "infineon,ir35219";
> 
> There's no driver for these in our tree. Do you have one coming?

Eddie will be writing one [Swift VDD VRM device driver 
#311](https://github.com/ibm-openbmc/dev/issues/311)
Should we put this patch on hold until the driver is done?


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH dev-5.1] ARM: dts: aspeed: swift: Add VDD (IR35219) devices
  2019-06-03 19:38   ` Adriana Kobylak
@ 2019-06-03 23:04     ` Joel Stanley
  0 siblings, 0 replies; 4+ messages in thread
From: Joel Stanley @ 2019-06-03 23:04 UTC (permalink / raw)
  To: linux-aspeed

On Mon, 3 Jun 2019 at 19:37, Adriana Kobylak <anoo@linux.ibm.com> wrote:
>
> On 2019-06-03 04:06, Joel Stanley wrote:
> > On Fri, 31 May 2019 at 20:31, Adriana Kobylak <anoo@linux.ibm.com>
> > wrote:
> >>
> >> From: Adriana Kobylak <anoo@us.ibm.com>
> >>
> >> Add the VDD (IR35219) devices to the Swift device tree.
> >>
> >> +       ir35219 at 70 {
> >> +               compatible = "infineon,ir35219";
> >
> > There's no driver for these in our tree. Do you have one coming?
>
> Eddie will be writing one [Swift VDD VRM device driver
> #311](https://github.com/ibm-openbmc/dev/issues/311)
> Should we put this patch on hold until the driver is done?

Yes. We generally don't put things in the device tree if there's no driver.

Cheers,

Joel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-03 23:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-31 20:31 [PATCH dev-5.1] ARM: dts: aspeed: swift: Add VDD (IR35219) devices Adriana Kobylak
2019-06-03  9:06 ` Joel Stanley
2019-06-03 19:38   ` Adriana Kobylak
2019-06-03 23:04     ` Joel Stanley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox