Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [v6 0/4] Support pwm/tach driver for aspeed ast26xx
Date: Thu, 8 Jun 2023 08:37:57 +0200	[thread overview]
Message-ID: <797c61d2-b8f1-e80e-24b9-4c7a7d266080@linaro.org> (raw)
In-Reply-To: <20230608021839.12769-1-billy_tsai@aspeedtech.com>

On 08/06/2023 04:18, Billy Tsai wrote:
> Unlike the old design that the register setting of the TACH should based
> on the configure of the PWM. In ast26xx, the dependency between pwm and
> tach controller is eliminated and becomes a separate hardware block. One
> is used to provide pwm output and another is used to monitor the frequency
> of the input. Therefore, this patch serials implements them by writing the
> two driver "pwm-aspeed-ast2600.c" and "tach-aspeed-ast2600.c". The former
> is following the pwm subsystem which can apply the existed driver to
> controller the fan(pwm-fan.c), beeper(pwm-beeper.c) and so on. The latter
> is following the sysfs interface of hwmon to creat the node for fan
> monitor.

You like to ignore my comments... How did you implement them? Go one by
one - answer to v4 emails.

Best regards,
Krzysztof


      parent reply	other threads:[~2023-06-08  6:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08  2:18 [v6 0/4] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2023-06-08  2:18 ` [v6 1/4] dt-bindings: pwm: Add ASPEED PWM Control documentation Billy Tsai
2023-06-08  6:39   ` Krzysztof Kozlowski
2023-06-08  6:46   ` Krzysztof Kozlowski
2023-06-08  7:47     ` Billy Tsai
2023-06-08  7:54       ` Krzysztof Kozlowski
2023-06-08  8:21         ` Billy Tsai
2023-06-08  8:36           ` Krzysztof Kozlowski
2023-06-08  8:57             ` Billy Tsai
2023-06-08  9:26               ` Krzysztof Kozlowski
2023-06-08  8:39           ` Krzysztof Kozlowski
2023-06-08  9:15             ` Billy Tsai
2023-06-08  9:27               ` Krzysztof Kozlowski
2023-06-08  2:18 ` [v6 2/4] dt-bindings: hwmon: Add ASPEED TACH " Billy Tsai
2023-06-08  4:58   ` Guenter Roeck
2023-06-08  6:21     ` Billy Tsai
2023-06-08 13:18       ` Guenter Roeck
2023-06-28  5:30         ` Billy Tsai
2023-06-08  6:40   ` Krzysztof Kozlowski
2023-06-08  2:18 ` [v6 3/4] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2023-07-18  7:08   ` Thierry Reding
2023-06-08  2:18 ` [v6 4/4] hwmon: Add Aspeed ast2600 TACH support Billy Tsai
2023-06-08  5:01   ` Guenter Roeck
2023-06-08  6:37 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=797c61d2-b8f1-e80e-24b9-4c7a7d266080@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox