From: Guenter Roeck <linux@roeck-us.net>
To: linux-aspeed@lists.ozlabs.org
Subject: [v6 2/4] dt-bindings: hwmon: Add ASPEED TACH Control documentation
Date: Wed, 7 Jun 2023 21:58:27 -0700 [thread overview]
Message-ID: <c1c485b0-b68b-4db7-4b67-5d59f1ecb84e@roeck-us.net> (raw)
In-Reply-To: <20230608021839.12769-3-billy_tsai@aspeedtech.com>
On 6/7/23 19:18, Billy Tsai wrote:
> Document the compatible for aspeed,ast2600-tach device.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> ---
> .../bindings/hwmon/aspeed,ast2600-tach.yaml | 32 +++++++++++++++++++
> 1 file changed, 32 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml b/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml
> new file mode 100644
> index 000000000000..627aa00f2e92
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2021 Aspeed, Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/aspeed,ast2600-tach.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Aspeed Ast2600 Tach controller
> +
> +maintainers:
> + - Billy Tsai <billy_tsai@aspeedtech.com>
> +
> +description: |
> + The Aspeed Tach controller can support upto 1 fan input.
> +
The code says:
In Aspeed AST2600 SoC features 16 TACH controllers, with each
controller capable of supporting up to 1 input.
which is a bit different. I guess there are no examples anymore,
but I'd really like to see how this looks like in the devicetree file,
and how the driver is supposed to distinguish/select the 16 inputs.
> +properties:
> + compatible:
> + enum:
> + - aspeed,ast2600-tach
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - clocks
> + - resets
> +
> +additionalProperties: false
next prev parent reply other threads:[~2023-06-08 4:58 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 2:18 [v6 0/4] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2023-06-08 2:18 ` [v6 1/4] dt-bindings: pwm: Add ASPEED PWM Control documentation Billy Tsai
2023-06-08 6:39 ` Krzysztof Kozlowski
2023-06-08 6:46 ` Krzysztof Kozlowski
2023-06-08 7:47 ` Billy Tsai
2023-06-08 7:54 ` Krzysztof Kozlowski
2023-06-08 8:21 ` Billy Tsai
2023-06-08 8:36 ` Krzysztof Kozlowski
2023-06-08 8:57 ` Billy Tsai
2023-06-08 9:26 ` Krzysztof Kozlowski
2023-06-08 8:39 ` Krzysztof Kozlowski
2023-06-08 9:15 ` Billy Tsai
2023-06-08 9:27 ` Krzysztof Kozlowski
2023-06-08 2:18 ` [v6 2/4] dt-bindings: hwmon: Add ASPEED TACH " Billy Tsai
2023-06-08 4:58 ` Guenter Roeck [this message]
2023-06-08 6:21 ` Billy Tsai
2023-06-08 13:18 ` Guenter Roeck
2023-06-28 5:30 ` Billy Tsai
2023-06-08 6:40 ` Krzysztof Kozlowski
2023-06-08 2:18 ` [v6 3/4] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2023-07-18 7:08 ` Thierry Reding
2023-06-08 2:18 ` [v6 4/4] hwmon: Add Aspeed ast2600 TACH support Billy Tsai
2023-06-08 5:01 ` Guenter Roeck
2023-06-08 6:37 ` [v6 0/4] Support pwm/tach driver for aspeed ast26xx Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2023-07-14 7:04 [v6 2/4] dt-bindings: hwmon: Add ASPEED TACH Control documentation 蔡承達
2023-07-14 7:13 ` Krzysztof Kozlowski
2023-07-14 9:59 ` Guenter Roeck
2023-07-14 10:18 ` 蔡承達
2023-07-14 10:26 ` Guenter Roeck
2023-07-14 11:17 ` 蔡承達
2023-07-16 16:08 ` Krzysztof Kozlowski
2023-07-16 17:00 ` Guenter Roeck
2023-07-17 9:01 ` 蔡承達
2023-07-17 9:39 ` Krzysztof Kozlowski
2023-07-18 4:01 ` 蔡承達
2023-07-18 6:04 ` Krzysztof Kozlowski
2023-07-18 6:39 ` Thierry Reding
2023-07-18 6:54 ` Guenter Roeck
2023-07-18 7:14 ` Thierry Reding
2023-08-15 6:32 ` 蔡承達
2023-07-18 6:45 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1c485b0-b68b-4db7-4b67-5d59f1ecb84e@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox