* [PATCH] fsi: aspeed: drop GPIOD_FLAGS_BIT_NONEXCLUSIVE
@ 2026-11-03 13:20 Bartosz Golaszewski
2026-11-17 8:32 ` Bartosz Golaszewski
2026-11-20 15:39 ` Eddie James
0 siblings, 2 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2026-11-03 13:20 UTC (permalink / raw)
To: Eddie James, Ninad Palsule, Joel Stanley, Andrew Jeffery,
Ryan Chen, Billy Tsai, Linus Walleij, Bartosz Golaszewski
Cc: linux-fsi, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-gpio, Bartosz Golaszewski
There are no users that share fsi-routing-gpios in any of the upstream
DT sources. Even if there were, the right thing to do would be enable
HAVE_SHARED_GPIOS for the aspeed platform as this is the preferred way
of sharing GPIO pins. Don't request the GPIO as non-exclusive as this
flag is now deprecated and will be removed.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/fsi/fsi-master-aspeed.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi-master-aspeed.c
index aa1380cdff338dfef7caa8d516322e6bf90371cd..88a3a90abef9cd22cae03f5666936ef7eced8a7d 100644
--- a/drivers/fsi/fsi-master-aspeed.c
+++ b/drivers/fsi/fsi-master-aspeed.c
@@ -496,8 +496,7 @@ static int tacoma_cabled_fsi_fixup(struct device *dev)
* The routing GPIO is a jumper indicating we should mux for the
* externally connected FSI cable.
*/
- routing_gpio = devm_gpiod_get_optional(dev, "fsi-routing",
- GPIOD_IN | GPIOD_FLAGS_BIT_NONEXCLUSIVE);
+ routing_gpio = devm_gpiod_get_optional(dev, "fsi-routing", GPIOD_IN);
if (IS_ERR(routing_gpio))
return PTR_ERR(routing_gpio);
if (!routing_gpio)
---
base-commit: 2637bdec0535a2044cd830eba9a79363651d9043
change-id: 20261103-fsi-aspeed-gpio-nonexclusive-3dda6d175968
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fsi: aspeed: drop GPIOD_FLAGS_BIT_NONEXCLUSIVE
2026-11-03 13:20 [PATCH] fsi: aspeed: drop GPIOD_FLAGS_BIT_NONEXCLUSIVE Bartosz Golaszewski
@ 2026-11-17 8:32 ` Bartosz Golaszewski
2026-11-20 15:39 ` Eddie James
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2026-11-17 8:32 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Eddie James, Ninad Palsule, Joel Stanley, Andrew Jeffery,
Ryan Chen, Billy Tsai, Linus Walleij, linux-fsi, linux-arm-kernel,
linux-aspeed, linux-kernel, linux-gpio
On Tue, Nov 03, 2026 at 02:20:42PM +0100, Bartosz Golaszewski wrote:
> There are no users that share fsi-routing-gpios in any of the upstream
> DT sources. Even if there were, the right thing to do would be enable
> HAVE_SHARED_GPIOS for the aspeed platform as this is the preferred way
> of sharing GPIO pins. Don't request the GPIO as non-exclusive as this
> flag is now deprecated and will be removed.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
Hi!
Gentle ping for this.
Thanks,
Bartosz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fsi: aspeed: drop GPIOD_FLAGS_BIT_NONEXCLUSIVE
2026-11-03 13:20 [PATCH] fsi: aspeed: drop GPIOD_FLAGS_BIT_NONEXCLUSIVE Bartosz Golaszewski
2026-11-17 8:32 ` Bartosz Golaszewski
@ 2026-11-20 15:39 ` Eddie James
1 sibling, 0 replies; 3+ messages in thread
From: Eddie James @ 2026-11-20 15:39 UTC (permalink / raw)
To: Bartosz Golaszewski, Ninad Palsule, Joel Stanley, Andrew Jeffery,
Ryan Chen, Billy Tsai, Linus Walleij, Bartosz Golaszewski
Cc: linux-fsi, linux-arm-kernel, linux-aspeed, linux-kernel,
linux-gpio
On 11/3/26 7:20 AM, Bartosz Golaszewski wrote:
> There are no users that share fsi-routing-gpios in any of the upstream
> DT sources. Even if there were, the right thing to do would be enable
> HAVE_SHARED_GPIOS for the aspeed platform as this is the preferred way
> of sharing GPIO pins. Don't request the GPIO as non-exclusive as this
> flag is now deprecated and will be removed.
Thanks!
Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> drivers/fsi/fsi-master-aspeed.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi-master-aspeed.c
> index aa1380cdff338dfef7caa8d516322e6bf90371cd..88a3a90abef9cd22cae03f5666936ef7eced8a7d 100644
> --- a/drivers/fsi/fsi-master-aspeed.c
> +++ b/drivers/fsi/fsi-master-aspeed.c
> @@ -496,8 +496,7 @@ static int tacoma_cabled_fsi_fixup(struct device *dev)
> * The routing GPIO is a jumper indicating we should mux for the
> * externally connected FSI cable.
> */
> - routing_gpio = devm_gpiod_get_optional(dev, "fsi-routing",
> - GPIOD_IN | GPIOD_FLAGS_BIT_NONEXCLUSIVE);
> + routing_gpio = devm_gpiod_get_optional(dev, "fsi-routing", GPIOD_IN);
> if (IS_ERR(routing_gpio))
> return PTR_ERR(routing_gpio);
> if (!routing_gpio)
>
> ---
> base-commit: 2637bdec0535a2044cd830eba9a79363651d9043
> change-id: 20261103-fsi-aspeed-gpio-nonexclusive-3dda6d175968
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-20 15:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-03 13:20 [PATCH] fsi: aspeed: drop GPIOD_FLAGS_BIT_NONEXCLUSIVE Bartosz Golaszewski
2026-11-17 8:32 ` Bartosz Golaszewski
2026-11-20 15:39 ` Eddie James
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox