Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Chen <ryan_chen@aspeedtech.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v3 2/4] dt-bindings: Add AST2700 bindings
Date: Thu, 19 Sep 2024 07:15:28 +0000	[thread overview]
Message-ID: <OS8PR06MB7541F08D97EC0CF83F8B36ACF2632@OS8PR06MB7541.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <195a8bfe-e4d7-4140-9635-b86a6ce3c663@kernel.org>

> Subject: Re: [PATCH v3 2/4] dt-bindings: Add AST2700 bindings
> 
> On 19/09/2024 08:01, Ryan Chen wrote:
> >> Subject: Re: [PATCH v3 2/4] dt-bindings: Add AST2700 bindings
> >>
> >> On 16/09/2024 11:10, Ryan Chen wrote:
> >>> Add reset, clock dt bindings for AST2700.
> >>>
> >>> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> >>> ---
> >>>  .../dt-bindings/clock/aspeed,ast2700-clk.h    | 163
> >> ++++++++++++++++++
> >>>  .../dt-bindings/reset/aspeed,ast2700-reset.h  | 124 +++++++++++++
> >>>  2 files changed, 287 insertions(+)
> >>
> >> This is supposed to be part of the commit adding these bindings. You
> >> got this comment already, didn't you?
> >
> > Sorry, I may mis-understood your point in previous.
> > I think you are ask, yaml and dt-binding header to be the same patch, right?
> 
> It is one patch adding the binding for the device and headers.
Thanks.
> 
> >
> >>
> >>>  create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h
> >>>  create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.h
> >>>
> >>> diff --git a/include/dt-bindings/clock/aspeed,ast2700-clk.h
> >>> b/include/dt-bindings/clock/aspeed,ast2700-clk.h
> >>> new file mode 100644
> >>> index 000000000000..63021af3caf5
> >>> --- /dev/null
> >>> +++ b/include/dt-bindings/clock/aspeed,ast2700-clk.h
> >>
> >> Use compatible as filename.
> > Modify from aspeed,ast2700-clk.h to aspeed, clk-ast2700.h, is it ok?
> > How about the aspeed,ast2700-reset.h file name is ok ?
> 
> No. For both use the same filename, so the full compatible. FULL.

Do you mean remove aspeed,ast2700-reset.h?
And move reset information into "aspeed, clk-ast2700.h"
> 
> Best regards,
> Krzysztof


  reply	other threads:[~2024-09-19  7:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16  9:10 [PATCH v3 0/4] Add support for AST2700 clk driver Ryan Chen
2024-09-16  9:10 ` [PATCH v3 1/4] dt-bindings: mfd: aspeed: support for AST2700 Ryan Chen
2024-09-16 10:08   ` Krzysztof Kozlowski
2024-09-19  6:05     ` Ryan Chen
2024-09-19  6:57       ` Krzysztof Kozlowski
2024-09-19  7:13         ` Ryan Chen
2024-09-19 10:32           ` Krzysztof Kozlowski
2024-09-20  7:33             ` Ryan Chen
2024-09-16  9:10 ` [PATCH v3 2/4] dt-bindings: Add AST2700 bindings Ryan Chen
2024-09-16 10:06   ` Krzysztof Kozlowski
2024-09-19  6:01     ` Ryan Chen
2024-09-19  6:58       ` Krzysztof Kozlowski
2024-09-19  7:15         ` Ryan Chen [this message]
2024-09-19 10:30           ` Krzysztof Kozlowski
2024-09-20  7:31             ` Ryan Chen
2024-09-16  9:10 ` [PATCH v3 3/4] reset: aspeed: register AST2700 reset auxiliary bus device Ryan Chen
2024-09-16 18:41   ` Christophe JAILLET
2024-09-23  2:50     ` Ryan Chen
2024-09-16  9:10 ` [PATCH v3 4/4] clk: aspeed: add AST2700 clock driver Ryan Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OS8PR06MB7541F08D97EC0CF83F8B36ACF2632@OS8PR06MB7541.apcprd06.prod.outlook.com \
    --to=ryan_chen@aspeedtech.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox