public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Klaus Heinrich Kiwi <klausk@linux.vnet.ibm.com>
To: eparis@redhat.com, "sgrubb@redhat.com" <sgrubb@redhat.com>,
	"Linux-audit@redhat.com" <Linux-audit@redhat.com>
Subject: [PATCH] [AUDIT] Fix ANOM_PROMISCUOUS message format
Date: Thu, 10 Jan 2008 15:25:23 -0200	[thread overview]
Message-ID: <1199985923.7836.63.camel@klausk.br.ibm.com> (raw)

Steve, as we talked earlier through IRC, ausearch/aureport are expecting
the kernel anomalies messages to have auid= uid= gid= fields (in this
order). This quick patch changes the ANOM_PROMISCUOUS message to the
correct format (as already used by ANOM_ABEND).

Applies on 2.6.24-rc7 from the audit.git tree

-- 
Klaus Heinrich Kiwi
Security Development - IBM Linux Technology Center

--

Fix ANOM_PROMISCUOUS message to the format as expected by
audit userspace: auid=%u uid=%u gid=%u [...]

Signed-off-by: Klaus Heinrich Kiwi <klausk@br.ibm.com>
---
 net/core/dev.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 0848da3..cd49cd0 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2759,10 +2759,11 @@ static void __dev_set_promiscuity(struct net_device *dev, int inc)
 							       "left");
 		audit_log(current->audit_context, GFP_ATOMIC,
 			AUDIT_ANOM_PROMISCUOUS,
-			"dev=%s prom=%d old_prom=%d auid=%u ses=%u",
+			"auid=%u uid=%u gid=%u dev=%s prom=%d old_prom=%d ses=%u",
+			audit_get_loginuid(current->audit_context),
+			current->uid, current->gid,
 			dev->name, (dev->flags & IFF_PROMISC),
 			(old_flags & IFF_PROMISC),
-			audit_get_loginuid(current->audit_context),
 			audit_get_sessionid(current->audit_context));
 
 		if (dev->change_rx_flags)
-- 
1.5.3.7

             reply	other threads:[~2008-01-10 17:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10 17:25 Klaus Heinrich Kiwi [this message]
2008-01-10 17:41 ` [PATCH] [AUDIT] Fix ANOM_PROMISCUOUS message format Steve Grubb
2008-01-10 17:49   ` Steve Grubb
2008-01-10 17:58   ` Klaus Heinrich Kiwi
2008-01-10 18:22     ` Steve Grubb
2008-01-10 19:44       ` [PATCH v2] [AUDIT] Add uid, gid fields to ANOM_PROMISCUOUS message Klaus Heinrich Kiwi
2008-01-10 20:05         ` Eric Paris
2008-01-10 18:07 ` [PATCH] [AUDIT] Fix ANOM_PROMISCUOUS message format Eric Paris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1199985923.7836.63.camel@klausk.br.ibm.com \
    --to=klausk@linux.vnet.ibm.com \
    --cc=Linux-audit@redhat.com \
    --cc=eparis@redhat.com \
    --cc=sgrubb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox