public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Klaus Heinrich Kiwi <klausk@linux.vnet.ibm.com>
Cc: "Linux-audit@redhat.com" <Linux-audit@redhat.com>
Subject: Re: [PATCH] [AUDIT] Fix ANOM_PROMISCUOUS message format
Date: Thu, 10 Jan 2008 12:41:00 -0500	[thread overview]
Message-ID: <200801101241.00467.sgrubb@redhat.com> (raw)
In-Reply-To: <1199985923.7836.63.camel@klausk.br.ibm.com>

On Thursday 10 January 2008 12:25:23 Klaus Heinrich Kiwi wrote:
> Steve, as we talked earlier through IRC, ausearch/aureport are expecting
> the kernel anomalies messages to have auid= uid= gid= fields (in this
> order). This quick patch changes the ANOM_PROMISCUOUS message to the
> correct format (as already used by ANOM_ABEND).

Thanks, would you mind making 2 changes to this? Add a test for audit_enabled 
being true before calling audit_log...a long standing oversight. And add a 
field at the end "res=1" since this doesn't appear to be able to fail. I'm 
trying to get result fields in all events. 

I'd like to just touch this code one time since its in the network code.

Thanks,
-Steve

  reply	other threads:[~2008-01-10 17:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10 17:25 [PATCH] [AUDIT] Fix ANOM_PROMISCUOUS message format Klaus Heinrich Kiwi
2008-01-10 17:41 ` Steve Grubb [this message]
2008-01-10 17:49   ` Steve Grubb
2008-01-10 17:58   ` Klaus Heinrich Kiwi
2008-01-10 18:22     ` Steve Grubb
2008-01-10 19:44       ` [PATCH v2] [AUDIT] Add uid, gid fields to ANOM_PROMISCUOUS message Klaus Heinrich Kiwi
2008-01-10 20:05         ` Eric Paris
2008-01-10 18:07 ` [PATCH] [AUDIT] Fix ANOM_PROMISCUOUS message format Eric Paris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801101241.00467.sgrubb@redhat.com \
    --to=sgrubb@redhat.com \
    --cc=Linux-audit@redhat.com \
    --cc=klausk@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox