From: LC Bruzenak <lenny@magitekltd.com>
To: Miloslav Trmac <mitr@redhat.com>
Cc: linux-audit <linux-audit@redhat.com>
Subject: Re: [PATCH] Don't crash on unknown S_IFMT file modes
Date: Thu, 26 Mar 2009 07:41:00 -0500 [thread overview]
Message-ID: <1238071260.7013.141.camel@homeserver> (raw)
In-Reply-To: <1028938143.2404851238069172743.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
On Thu, 2009-03-26 at 08:06 -0400, Miloslav Trmac wrote:
> Hello,
> ausearch -i and libauparse currently crash (access NULL) if a mode= field contains an unknown file type. Such records are generated by the kernel for IPC, e.g.
>
> node=jcdx156 type=IPC msg=audit(1237915952.720:2294): ouid=500 ogid=1106 mode=0600 obj=siterep_u:siterep_r:siterep_t:s0-s15:c0.c1023
>
> The attached patch:
> * Modifies ausearch and libauparse to output the file format in octal if it is unknown.
> * Modifies libauparse to use the same interpreted field format as ausearch (without a space in the middle).
> * Modifies comma handling in libauparse to avoid a strcat() call.
>
> Mirek
Mirek,
Thank you for this patch...wherever it may be.
:)
I really appreciate you fixing this!
Do you have a standard auparse test you use to track these down?
If so, does it use auparse_feed?
Thanks again,
LCB.
--
LC (Lenny) Bruzenak
lenny@magitekltd.com
next prev parent reply other threads:[~2009-03-26 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 12:06 [PATCH] Don't crash on unknown S_IFMT file modes Miloslav Trmac
2009-03-26 12:41 ` LC Bruzenak [this message]
2009-04-06 14:34 ` Steve Grubb
[not found] <244499589.2433711238079841056.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2009-03-26 15:05 ` Miloslav Trmac
2009-03-27 15:44 ` LC Bruzenak
2009-03-27 15:55 ` Miloslav Trmac
2009-03-27 15:56 ` LC Bruzenak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238071260.7013.141.camel@homeserver \
--to=lenny@magitekltd.com \
--cc=linux-audit@redhat.com \
--cc=mitr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox