From: Miloslav Trmac <mitr@redhat.com>
To: LC Bruzenak <lenny@magitekltd.com>
Cc: linux-audit <linux-audit@redhat.com>
Subject: Re: [PATCH] Don't crash on unknown S_IFMT file modes
Date: Fri, 27 Mar 2009 11:55:00 -0400 (EDT) [thread overview]
Message-ID: <653655667.2560521238169300902.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <1238168675.7013.254.camel@homeserver>
----- "LC Bruzenak" <lenny@magitekltd.com> wrote:
> After applying this patch my build fails in the parse test section due
> to a difference of no space after a comma:
>
> - mode=040730 (dir, 730)
> + mode=040730 (dir,730)
>
> Do you think your changes would cause this?
Yes, that change was intentional and documented in the patch. I forgot to run (make check) and update the test case.
Mirek
next prev parent reply other threads:[~2009-03-27 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <244499589.2433711238079841056.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2009-03-26 15:05 ` [PATCH] Don't crash on unknown S_IFMT file modes Miloslav Trmac
2009-03-27 15:44 ` LC Bruzenak
2009-03-27 15:55 ` Miloslav Trmac [this message]
2009-03-27 15:56 ` LC Bruzenak
2009-03-26 12:06 Miloslav Trmac
2009-03-26 12:41 ` LC Bruzenak
2009-04-06 14:34 ` Steve Grubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=653655667.2560521238169300902.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com \
--to=mitr@redhat.com \
--cc=lenny@magitekltd.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox