From: Eric Paris <eparis@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org,
Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH] audit: remove newline accidentally added during session id helper refactor
Date: Fri, 20 Sep 2013 12:08:46 -0400 [thread overview]
Message-ID: <1379693326.5434.11.camel@flatline.rdu.redhat.com> (raw)
In-Reply-To: <0c842120dc69b8dadc143ee70c29094e1f9d5110.1379517385.git.rgb@redhat.com>
On Wed, 2013-09-18 at 11:17 -0400, Richard Guy Briggs wrote:
> A newline was accidentally added during session ID helper refactorization in
> commit 4d3fb709. This needlessly uses up buffer space, messes up syslog
> formatting and makes userspace processing less efficient. Remove it.
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Acked-by: Eric Paris <eparis@redhat.com>
> ---
> kernel/audit.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 3d17670..ac16540 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -1413,7 +1413,7 @@ void audit_log_session_info(struct audit_buffer *ab)
> u32 sessionid = audit_get_sessionid(current);
> uid_t auid = from_kuid(&init_user_ns, audit_get_loginuid(current));
>
> - audit_log_format(ab, " auid=%u ses=%u\n", auid, sessionid);
> + audit_log_format(ab, " auid=%u ses=%u", auid, sessionid);
> }
>
> void audit_log_key(struct audit_buffer *ab, char *key)
prev parent reply other threads:[~2013-09-20 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 15:17 [PATCH] audit: remove newline accidentally added during session id helper refactor Richard Guy Briggs
2013-09-20 16:08 ` Eric Paris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379693326.5434.11.camel@flatline.rdu.redhat.com \
--to=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgb@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox