* [PATCH] audit: remove newline accidentally added during session id helper refactor
@ 2013-09-18 15:17 Richard Guy Briggs
2013-09-20 16:08 ` Eric Paris
0 siblings, 1 reply; 2+ messages in thread
From: Richard Guy Briggs @ 2013-09-18 15:17 UTC (permalink / raw)
To: linux-audit, linux-kernel; +Cc: Richard Guy Briggs, Steve Grubb, Eric Paris
A newline was accidentally added during session ID helper refactorization in
commit 4d3fb709. This needlessly uses up buffer space, messes up syslog
formatting and makes userspace processing less efficient. Remove it.
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
---
kernel/audit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/audit.c b/kernel/audit.c
index 3d17670..ac16540 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1413,7 +1413,7 @@ void audit_log_session_info(struct audit_buffer *ab)
u32 sessionid = audit_get_sessionid(current);
uid_t auid = from_kuid(&init_user_ns, audit_get_loginuid(current));
- audit_log_format(ab, " auid=%u ses=%u\n", auid, sessionid);
+ audit_log_format(ab, " auid=%u ses=%u", auid, sessionid);
}
void audit_log_key(struct audit_buffer *ab, char *key)
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] audit: remove newline accidentally added during session id helper refactor
2013-09-18 15:17 [PATCH] audit: remove newline accidentally added during session id helper refactor Richard Guy Briggs
@ 2013-09-20 16:08 ` Eric Paris
0 siblings, 0 replies; 2+ messages in thread
From: Eric Paris @ 2013-09-20 16:08 UTC (permalink / raw)
To: Richard Guy Briggs; +Cc: linux-audit, linux-kernel, Steve Grubb
On Wed, 2013-09-18 at 11:17 -0400, Richard Guy Briggs wrote:
> A newline was accidentally added during session ID helper refactorization in
> commit 4d3fb709. This needlessly uses up buffer space, messes up syslog
> formatting and makes userspace processing less efficient. Remove it.
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Acked-by: Eric Paris <eparis@redhat.com>
> ---
> kernel/audit.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 3d17670..ac16540 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -1413,7 +1413,7 @@ void audit_log_session_info(struct audit_buffer *ab)
> u32 sessionid = audit_get_sessionid(current);
> uid_t auid = from_kuid(&init_user_ns, audit_get_loginuid(current));
>
> - audit_log_format(ab, " auid=%u ses=%u\n", auid, sessionid);
> + audit_log_format(ab, " auid=%u ses=%u", auid, sessionid);
> }
>
> void audit_log_key(struct audit_buffer *ab, char *key)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-20 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-18 15:17 [PATCH] audit: remove newline accidentally added during session id helper refactor Richard Guy Briggs
2013-09-20 16:08 ` Eric Paris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox