public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Mikhail Klementyev <jollheef@riseup.net>
Cc: rgb@redhat.com, linux-audit@redhat.com
Subject: Re: [PATCH 1/1] Obsolete check is now removed.
Date: Fri, 29 May 2015 16:15:25 -0400	[thread overview]
Message-ID: <1670382.DmuLZR64zR@sifl> (raw)
In-Reply-To: <5565C971.8020001@riseup.net>

On Wednesday, May 27, 2015 04:41:05 PM Mikhail Klementyev wrote:
> From a2e33ce7c9b5ceff2a8b570b570ddd0023ce077f Mon Sep 17 00:00:00 2001
> From: Mikhail Klementyev<jollheef@riseup.net>
> Date: Mon, 25 May 2015 23:20:38 +0300
> Subject: [PATCH 1/1] Obsolete check is now removed.
> 
> Signed-off-by: Mikhail Klementyev<jollheef@riseup.net>
> ---
>   kernel/auditsc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

Applied, but you are lucky I happened to be in a good mood and your patch was 
small, normally I reject patches that arrive as HTML mail because they are a 
major headache to apply.

Contributions are always welcome, but please read the information in the 
Documentation/SubmittingPatches before submitting another patch.

> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 9fb9d1c..ee09794 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -599,9 +599,7 @@ static int audit_filter_rules(struct task_struct *tsk,
>   				result = match_tree_refs(ctx, rule->tree);
>   			break;
>   		case AUDIT_LOGINUID:
> -			result = 0;
> -			if (ctx)
> -				result = audit_uid_comparator(tsk->loginuid, f->op, f->uid);
> +			result = audit_uid_comparator(tsk->loginuid, f->op, f->uid);
>   			break;
>   		case AUDIT_LOGINUID_SET:
>   			result = audit_comparator(audit_loginuid_set(tsk), f->op, f-
>val);
> --
> 2.0.5

-- 
paul moore
www.paul-moore.com

      reply	other threads:[~2015-05-29 20:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 13:41 [PATCH 1/1] Obsolete check is now removed Mikhail Klementyev
2015-05-29 20:15 ` Paul Moore [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1670382.DmuLZR64zR@sifl \
    --to=paul@paul-moore.com \
    --cc=jollheef@riseup.net \
    --cc=linux-audit@redhat.com \
    --cc=rgb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox