public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: linux-audit@redhat.com, burn@swtf.dyndns.org
Subject: Re: How to offer a patch
Date: Tue, 02 Apr 2013 14:55:13 -0400	[thread overview]
Message-ID: <1872448.Hxgm3VXBsz@x2> (raw)
In-Reply-To: <1364690677.30850.18.camel@swtf.swtf.dyndns.org>

On Sunday, March 31, 2013 11:44:37 AM Burn Alting wrote:
> I've made some mods to auditctl to allow it to read a directory of 'rule
> files'. The idea is that within an enterprise, one would distribute a
> standard /etc/audit/audit.rules which can be updated from the corporate
> repository. Should a system require localized audit rules, then a
> directory containing files of rules can be maintained locally. The
> reasoning for a directory as opposed to just an additional file is to
> offer granularity of 'rule sets'.

See the previous email about SCAP limitations.


> I would like to know the convention for patching to this list. Should I
> git clone the svn repository then supply a git diff? Can I just provide
> an old-fashioned diff -rupN or C_ALL=C TZ=UTC0 diff -Naur?

As long as it can be applied with 'patch', I can figure out whether its -p0 or 
-p1. I generally go for the diff -urpN option. It probably doesn't need to be 
mentioned, but I don't like patches (or sections of patches) that only add 
formatting or white spaces to existing code.

Thanks,
-Steve

      reply	other threads:[~2013-04-02 18:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-31  0:44 How to offer a patch Burn Alting
2013-04-02 18:55 ` Steve Grubb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1872448.Hxgm3VXBsz@x2 \
    --to=sgrubb@redhat.com \
    --cc=burn@swtf.dyndns.org \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox