From: Steve Grubb <sgrubb@redhat.com>
To: Alexander Viro <aviro@redhat.com>
Cc: akpm@osdl.org, linux-audit@redhat.com
Subject: Re: moving audit_free() up into do_exit()
Date: Fri, 31 Mar 2006 15:40:30 -0500 [thread overview]
Message-ID: <200603311540.30301.sgrubb@redhat.com> (raw)
In-Reply-To: <20060330085638.GQ1727@devserv.devel.redhat.com>
On Thursday 30 March 2006 03:56, Alexander Viro wrote:
> On Thu, Mar 30, 2006 at 03:54:53AM -0500, Alexander Viro wrote:
> > OK, preliminary patches attached; the first one is minimal "take care of
>
> Gah... Attached to this followup; my apologies.
In audit-exit.patch
@@ -607,12 +605,12 @@ static void audit_log_exit(struct audit_
context->gid,
context->euid, context->suid, context->fsuid,
context->egid, context->sgid, context->fsgid, tty);
- audit_log_task_info(ab, gfp_mask);
+ audit_log_task_info(ab);
audit_log_end(ab);
for (aux = context->aux; aux; aux = aux->next) {
- ab = audit_log_start(context, gfp_mask, aux->type);
+ ab = audit_log_start(context, GFP_KERNEL, aux->type);
if (!ab)
continue; /* audit_panic has been called */
It doesn't compile....it needs:
+ audit_log_task_info(ab, tsk);
Also, piece in kernel/exit.c complains of implicit declaration of
'audit_free'.
-Steve
next parent reply other threads:[~2006-03-31 20:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060329220358.GN1727@devserv.devel.redhat.com>
[not found] ` <20060330085453.GP1727@devserv.devel.redhat.com>
[not found] ` <20060330085638.GQ1727@devserv.devel.redhat.com>
2006-03-31 20:40 ` Steve Grubb [this message]
2006-03-31 21:41 ` moving audit_free() up into do_exit() Alexander Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603311540.30301.sgrubb@redhat.com \
--to=sgrubb@redhat.com \
--cc=akpm@osdl.org \
--cc=aviro@redhat.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox