From: "Timothy R. Chavez" <tinytim@ibm.com>
To: Alexander Viro <aviro@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: close(2) not being audited?
Date: Fri, 26 Jan 2007 18:03:22 -0600 [thread overview]
Message-ID: <20070126180322.74db01da@crumpet> (raw)
In-Reply-To: <20070126232910.GH14621@devserv.devel.redhat.com>
On Fri, 26 Jan 2007 18:29:10 -0500
Alexander Viro <aviro@redhat.com> wrote:
> On Fri, Jan 26, 2007 at 05:01:12PM -0600, Timothy R. Chavez wrote:
> > > What do you want in the log? More specifically, _when_ do you want it?
> >
> > Write out a log when the last reference to the fd is put back... whether
> > that's from a close or an munmap.
>
> BTW... Consider the following: threads A and B share descriptor table.
> Their stdin is a terminal.
> Apr 1: thread A calls read(0, buf, 512);
> Apr 2: thread B does close(0);
> May 1: user hits enter
>
> After Apr 2 we'll have descriptor 0 closed. Thread A is still sitting in
> read() and it couldn't care less about descriptors. The file is still
> opened, even though all descriptors are gone.
>
> On May 1 read() in thread A finally completes. Upon exit from read()
> we give up a reference to file, so it finally gets closed.
>
> IOW, you'll get "it's been closed by read(2)" in logs. The same
> may apply to any system call doing file IO. So userland would better
> not assume that something recognizable is doing that...
That seems perfectly reasonable to me.
-tim
prev parent reply other threads:[~2007-01-27 0:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-28 21:58 close(2) not being audited? Todd, Charles
2006-12-30 14:36 ` Steve Grubb
2007-01-26 17:37 ` Steve Grubb
2007-01-26 18:03 ` John D. Ramsdell
2007-01-26 20:14 ` Wieprecht, Karen M.
2007-01-26 22:19 ` Alexander Viro
2007-01-26 23:00 ` Timothy R. Chavez
2007-01-26 23:01 ` Timothy R. Chavez
2007-01-26 23:20 ` Alexander Viro
2007-01-26 23:46 ` Timothy R. Chavez
2007-01-28 21:40 ` James Antill
2007-01-29 20:19 ` Timothy R. Chavez
2007-01-26 23:29 ` Alexander Viro
2007-01-27 0:03 ` Timothy R. Chavez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070126180322.74db01da@crumpet \
--to=tinytim@ibm.com \
--cc=aviro@redhat.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox