public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Alexander Viro <aviro@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: Audit issue
Date: Thu, 8 Nov 2007 09:47:40 -0500	[thread overview]
Message-ID: <200711080947.41645.sgrubb@redhat.com> (raw)
In-Reply-To: <20071108143218.GB28304@devserv.devel.redhat.com>

On Thursday 08 November 2007 09:32:18 Alexander Viro wrote:
> > Thanks for posting this patch. Is it impossible to "repair " processes by
> > simply adding a context if the pointer is NULL?
>
> At which point would you do that?

Possibly on syscall exit? Shouldn't the kernel have released all locks by that 
point? And what about syscall entry...isn't that before any locking starts to 
occur?

> I'd rather not try to play with locking, etc., when we set audit_enabled to
> non-zero...

Sure.

> Especially when there's a trivially non-intrusive patch.

True, but I'm thinking this will cause performance to go down if the audit 
system was ever enabled. It doesn't look as bad as the audit system actually 
being on, but it may be doing unnecessary allocations I think.

-Steve

  reply	other threads:[~2007-11-08 14:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200710301248.24261.sgrubb@redhat.com>
     [not found] ` <200710301907.29505.sgrubb@redhat.com>
     [not found]   ` <20071030231525.GG12499@devserv.devel.redhat.com>
     [not found]     ` <200710311740.19981.sgrubb@redhat.com>
2007-11-08 14:19       ` Audit issue Alexander Viro
2007-11-08 14:27         ` Steve Grubb
2007-11-08 14:32           ` Alexander Viro
2007-11-08 14:47             ` Steve Grubb [this message]
2007-11-08 14:56               ` Alexander Viro
2007-11-08 14:59                 ` Steve Grubb
2007-11-09  0:28                   ` Steve Grubb
2007-11-08 14:35           ` Eric Paris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711080947.41645.sgrubb@redhat.com \
    --to=sgrubb@redhat.com \
    --cc=aviro@redhat.com \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox