public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: klausk@br.ibm.com
Cc: "Linux-audit@redhat.com" <Linux-audit@redhat.com>,
	linux-audit-bounces@redhat.com
Subject: Re: auparse_interpret_field()
Date: Fri, 9 Nov 2007 15:17:58 -0500	[thread overview]
Message-ID: <200711091517.59953.sgrubb@redhat.com> (raw)
In-Reply-To: <OF209A8D73.B1D992BE-ON8525738E.006D0615-8525738E.006DDEFC@br.ibm.com>

On Friday 09 November 2007 14:56:05 klausk@br.ibm.com wrote:
> See that 'r->machine' and 'r->syscall' are only filled when the 'arch'
> field in found in the 2nd position, and syscall in the 3rd position
> respectively. That is not true when the dispatcher is appending a 'node='
> field to each record.

Yeah I put a FIXME in the code for that a little while ago. It needs to be 
flexible.

> I would provide a patch myself, but I'm not sure why you need to check the
> field position in this function (I mean, if the field is arch=, wouldn't
> it be interpreted no matter what position it is?)

Speed. I wanted a way to only check these things once and not slow it down for 
each field. This is where the record is getting split up, so we can do 
anything but simple checks.

-Steve

  reply	other threads:[~2007-11-09 20:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-08 22:26 auparse_interpret_field() Klaus Heinrich Kiwi
2007-11-09 17:15 ` auparse_interpret_field() klausk
2007-11-09 17:56   ` auparse_interpret_field() Steve Grubb
2007-11-09 19:56     ` auparse_interpret_field() klausk
2007-11-09 20:17       ` Steve Grubb [this message]
2007-11-14 18:34       ` auparse_interpret_field() Steve Grubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711091517.59953.sgrubb@redhat.com \
    --to=sgrubb@redhat.com \
    --cc=Linux-audit@redhat.com \
    --cc=klausk@br.ibm.com \
    --cc=linux-audit-bounces@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox