public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Peng Haitao <penght@cn.fujitsu.com>
Cc: linux-audit@redhat.com, dwmw2@infradead.org
Subject: Re: The second argument "type" is not used in audit_filter_user()
Date: Mon, 19 May 2008 13:11:48 -0400	[thread overview]
Message-ID: <200805191311.49294.sgrubb@redhat.com> (raw)
In-Reply-To: <482D4F73.5080404@cn.fujitsu.com>

On Friday 16 May 2008 05:10:11 am Peng Haitao wrote:
> I find the second argument "type" is not used in audit_filter_user().

I researched this all the way back to our RHEL4 kernel. This appears to be in 
every kernel I can find. I don't know what its original purpose is, but it 
does appear to be unused. Its not on a performance critical path, but should 
be cleaned up just on the principal of it. Someone should submit a patch 
deleting this argument.

-Steve

      reply	other threads:[~2008-05-19 17:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-16  9:10 The second argument "type" is not used in audit_filter_user() Peng Haitao
2008-05-19 17:11 ` Steve Grubb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805191311.49294.sgrubb@redhat.com \
    --to=sgrubb@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-audit@redhat.com \
    --cc=penght@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox