public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
* [PATCH] fix a bug that output of "aureport -au" is imperfection
@ 2008-07-22  8:18 Peng Haitao
  2008-07-22 23:16 ` Steve Grubb
  0 siblings, 1 reply; 2+ messages in thread
From: Peng Haitao @ 2008-07-22  8:18 UTC (permalink / raw)
  To: sgrubb; +Cc: audit-list

Hello Steve, 

Execute command "aureport -au", the output is imperfection.

For example:
[root@RHEL5 ~]# aureport -au

Authentication Report
============================================
# date time acct host term exe success event
============================================
1. 07/22/2008 09:24:39 acct="aulltest rhel5.2ga ssh /usr/sbin/sshd yes 5208350

The reports have a column label at the top to help with interpretation of the various fields,
So 'acct="aulltest' should be modified to 'aulltest' in the line 1.

Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
---
 src/ausearch-parse.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/ausearch-parse.c b/src/ausearch-parse.c
index 5fdf8c7..141fdee 100644
--- a/src/ausearch-parse.c
+++ b/src/ausearch-parse.c
@@ -786,7 +786,8 @@ static int parse_user(const lnode *n, search_items *s)
 					term++;
 				saved = *term;
 				*term = 0;
-				s->acct = strdup(str);
+				ptr++;
+				s->acct = strdup(ptr);
 				*term = saved;
 			} else { 
 				/* Handle legacy accts */
@@ -802,11 +803,11 @@ static int parse_user(const lnode *n, search_items *s)
 				}
 				term = end;
 				if (!legacy)
-					s->acct = unescape(str);
+					s->acct = unescape(ptr);
 				else {
 					saved = *term;
 					*term = 0;
-					s->acct = strdup(str);
+					s->acct = strdup(ptr);
 					*term = saved;
 				}
 			}


-- 
Regards
Peng Haitao

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix a bug that output of "aureport -au" is imperfection
  2008-07-22  8:18 [PATCH] fix a bug that output of "aureport -au" is imperfection Peng Haitao
@ 2008-07-22 23:16 ` Steve Grubb
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Grubb @ 2008-07-22 23:16 UTC (permalink / raw)
  To: Peng Haitao; +Cc: audit-list

On Tuesday 22 July 2008 04:18:59 Peng Haitao wrote:
> The reports have a column label at the top to help with interpretation of
> the various fields, So 'acct="aulltest' should be modified to 'aulltest' in
> the line 1.

Thanks for the patch.

-Steve

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-07-22 23:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-22  8:18 [PATCH] fix a bug that output of "aureport -au" is imperfection Peng Haitao
2008-07-22 23:16 ` Steve Grubb

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox