From: Steve Grubb <sgrubb@redhat.com>
To: Chu Li <chul@cn.fujitsu.com>
Cc: 'linux-audit' <linux-audit@redhat.com>
Subject: Re: [PATCH]Delete unnecessary codes in auditd-config.c and audispd-pconfig.c
Date: Thu, 7 Aug 2008 16:47:04 -0400 [thread overview]
Message-ID: <200808071647.05087.sgrubb@redhat.com> (raw)
In-Reply-To: <005a01c8f845$cda16f00$958da70a@truly>
On Thursday 07 August 2008 00:26:46 Chu Li wrote:
> I think such codes about "basename" in auditd-config.c and
> audispd-pconfig.c is unnecessary. In these part "nv->value" can't be null
> and "basename()" will never return an empty string. And the variable "base"
> is not used in the following codes. So such codes are better to be deleted.
Applied. Thanks for the patch !
-Steve
next prev parent reply other threads:[~2008-08-07 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 4:26 [PATCH]Delete unnecessary codes in auditd-config.c and audispd-pconfig.c Chu Li
2008-08-07 20:47 ` Steve Grubb [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-08-07 4:23 Chu Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808071647.05087.sgrubb@redhat.com \
--to=sgrubb@redhat.com \
--cc=chul@cn.fujitsu.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox