From: Richard Guy Briggs <rgb@redhat.com>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: akpm@linux-foundation.org, linux-audit@redhat.com
Subject: Re: [PATCH] Audit: remove duplicate comments
Date: Mon, 23 Sep 2013 11:28:35 -0400 [thread overview]
Message-ID: <20130923152835.GS13968@madcap2.tricolour.ca> (raw)
In-Reply-To: <52405B37.1010304@schaufler-ca.com>
On Mon, Sep 23, 2013 at 08:16:07AM -0700, Casey Schaufler wrote:
> On 9/23/2013 12:55 AM, Gao feng wrote:
> > Remove it.
>
> Why? Is it inaccurate?
Yes. It is a duplicate from 8 years ago that is no longer accurate.
> > Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
> > ---
> > kernel/audit.c | 7 -------
> > 1 file changed, 7 deletions(-)
> >
> > diff --git a/kernel/audit.c b/kernel/audit.c
> > index 91e53d0..f94db2a 100644
> > --- a/kernel/audit.c
> > +++ b/kernel/audit.c
> > @@ -1067,13 +1067,6 @@ static void wait_for_auditd(unsigned long sleep_time)
> > remove_wait_queue(&audit_backlog_wait, &wait);
> > }
> >
> > -/* Obtain an audit buffer. This routine does locking to obtain the
> > - * audit buffer, but then no locking is required for calls to
> > - * audit_log_*format. If the tsk is a task that is currently in a
> > - * syscall, then the syscall is marked as auditable and an audit record
> > - * will be written at syscall exit. If there is no associated task, tsk
> > - * should be NULL. */
> > -
> > /**
> > * audit_log_start - obtain an audit buffer
> > * @ctx: audit_context (may be NULL)
>
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit
- RGB
--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer
Kernel Security
AMER ENG Base Operating Systems
Remote, Ottawa, Canada
Voice: +1.647.777.2635
Internal: (81) 32635
Alt: +1.613.693.0684x3545
prev parent reply other threads:[~2013-09-23 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 7:55 [PATCH] Audit: remove duplicate comments Gao feng
2013-09-23 15:16 ` Casey Schaufler
2013-09-23 15:28 ` Richard Guy Briggs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923152835.GS13968@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=casey@schaufler-ca.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox