From: Richard Guy Briggs <rgb@redhat.com>
To: Mathias Krause <minipli@googlemail.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH 1/2] audit: fix info leak in AUDIT_GET requests
Date: Mon, 30 Sep 2013 22:20:13 -0400 [thread overview]
Message-ID: <20131001022013.GE13968@madcap2.tricolour.ca> (raw)
In-Reply-To: <1380571465-15440-2-git-send-email-minipli@googlemail.com>
On Mon, Sep 30, 2013 at 10:04:24PM +0200, Mathias Krause wrote:
> We leak 4 bytes of kernel stack in response to an AUDIT_GET request as
> we miss to initialize the mask member of status_set. Fix that.
Thank you.
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Eric Paris <eparis@redhat.com>
> Cc: stable@vger.kernel.org # v2.6.6+
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> ---
> kernel/audit.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 7b0e23a..e237712 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -659,6 +659,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
>
> switch (msg_type) {
> case AUDIT_GET:
> + status_set.mask = 0;
> status_set.enabled = audit_enabled;
> status_set.failure = audit_failure;
> status_set.pid = audit_pid;
> --
> 1.7.10.4
>
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit
- RGB
--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer
Kernel Security
AMER ENG Base Operating Systems
Remote, Ottawa, Canada
Voice: +1.647.777.2635
Internal: (81) 32635
Alt: +1.613.693.0684x3545
next prev parent reply other threads:[~2013-10-01 2:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 20:04 [PATCH 0/2] netlink related fixes Mathias Krause
2013-09-30 20:04 ` [PATCH 1/2] audit: fix info leak in AUDIT_GET requests Mathias Krause
2013-10-01 2:20 ` Richard Guy Briggs [this message]
2013-09-30 20:04 ` [PATCH 2/2] audit: use nlmsg_len() to get message payload length Mathias Krause
2013-10-01 3:51 ` Richard Guy Briggs
2013-10-01 6:33 ` Mathias Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001022013.GE13968@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=minipli@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox