public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Paul Davies C <pauldaviesc@gmail.com>
To: linux-audit@redhat.com, viro@zeniv.linux.org.uk, eparis@redhat.com
Subject: [PATCH] Fixed reason field in audit signal logging
Date: Thu, 7 Nov 2013 19:09:32 +0530	[thread overview]
Message-ID: <20131107133932.GA10317@pauldc-Inspiron-1470> (raw)

The audit system logs the signals that leads to abnormal end of a process.
However , as of now , it always states the reason for failure of a process as
"memory violation" regardless of the signal delivered. This is due to the
audit_core_dumps() function pass the reason for failure blindly to the
audit_log_abend() as "memory violation".

This patch changes the audit_core_dumps() function as to pass on the right
reason to the audit_log_abend based on the signal received.

Signed-off-by:Paul Davies C
---
 kernel/auditsc.c |   31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 9845cb3..3cafd13 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -2395,7 +2395,36 @@ void audit_core_dumps(long signr)
 	ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_ANOM_ABEND);
 	if (unlikely(!ab))
 		return;
-	audit_log_abend(ab, "memory violation", signr);
+
+	/*Identify the reason for failure based on signal delivered.*/
+	switch (signr) {
+	case SIGABRT:
+			audit_log_abend(ab, "received abort", signr);
+			break;
+	case SIGBUS:
+			audit_log_abend(ab, "invalid pointer dereference", signr);
+			break;
+	case SIGFPE:
+			audit_log_abend(ab, "invalid floating point instruction", signr);
+			break;
+	case SIGILL:
+			audit_log_abend(ab, "illegal instruction", signr);
+			break;
+	case SIGSEGV:
+			audit_log_abend(ab, "memory violation", signr);
+			break;
+	case SIGTRAP:
+			audit_log_abend(ab, "bad instruction / debugger generated signal", signr);
+			break;
+	case SIGXCPU:
+			audit_log_abend(ab, "cpu time violation", signr);
+			break;
+	case SIGXFSZ:
+			audit_log_abend(ab, "file size violation", signr);
+			break;
+	default:
+			audit_log_abend(ab, "not defined", signr);
+	}
 	audit_log_end(ab);
 }
 
-- 
1.7.9.5

             reply	other threads:[~2013-11-07 13:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 13:39 Paul Davies C [this message]
2013-11-07 14:43 ` [PATCH] Fixed reason field in audit signal logging Eric Paris
2013-11-07 14:52   ` LC Bruzenak
2013-11-07 15:05   ` Steve Grubb
2013-11-07 15:13     ` LC Bruzenak
2013-11-07 15:42     ` Eric Paris
2013-11-07 15:51       ` Paul Davies C
2013-11-07 15:53         ` Eric Paris
2013-11-07 16:00           ` Paul Davies C
2013-11-07 16:05             ` Eric Paris
2013-11-07 16:11       ` Steve Grubb
2013-11-07 18:07         ` Steve Grubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131107133932.GA10317@pauldc-Inspiron-1470 \
    --to=pauldaviesc@gmail.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox