Re: [PATCH] audit: fix build error when disable audit

[Richard Guy Briggs <rgb@redhat.com>]

On 13/12/20, Gao feng wrote:
> On 12/20/2013 09:19 AM, Richard Guy Briggs wrote:
> > On 13/12/19, Gao feng wrote:
> >> On 12/19/2013 10:34 AM, Gao feng wrote:
> >>> kernel/capability.c: In function ‘SYSC_capset’:
> >>> kernel/capability.c:280:2: warning: passing argument 1 of ‘audit_log_capset’ makes integer from pointer without a cast [enabled by default]
> >>>   audit_log_capset(new, current_cred());
> >>>   ^
> >>> In file included from kernel/capability.c:10:0:
> >>> include/linux/audit.h:400:20: note: expected ‘pid_t’ but argument is of type ‘struct cred *’
> >>>  static inline void audit_log_capset(pid_t pid, const struct cred *new,
> >>>                     ^
> >>> kernel/capability.c:280:2: error: too few arguments to function ‘audit_log_capset’
> >>>   audit_log_capset(new, current_cred());
> >>>   ^
> >>> In file included from kernel/capability.c:10:0:
> >>> include/linux/audit.h:400:20: note: declared here
> >>>  static inline void audit_log_capset(pid_t pid, const struct cred *new,
> >>>                     ^
> >>> make[1]: *** [kernel/capability.o] Error 1
> >>
> >> BTW, bug introduced by commmit 26b81eb408c411d86c7cc93278fb88fbcd785f65
> >> audit: Simplify and correct audit_log_capset
> > 
> > Yup, found it.  Thanks for the patch.  Since it isn't upstream yet, I
> > may merge it and rebase for linux-next.
> 
> thank you Richard, btw, do you have plan to push these changes to the linux-next?

Yes, that's where I'm putting all these, via Eric.

- RGB

--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545