From: Richard Guy Briggs <rgb@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, linux-audit@redhat.com,
linux-kernel@vger.kernel.org, sgrubb@redhat.com,
pmoore@redhat.com
Subject: Re: [PATCH][STABLE] audit: correct AUDIT_GET_FEATURE return message type
Date: Wed, 29 Oct 2014 14:56:04 -0400 [thread overview]
Message-ID: <20141029185604.GJ20866@madcap2.tricolour.ca> (raw)
In-Reply-To: <20141029162927.GG20866@madcap2.tricolour.ca>
On 14/10/29, Richard Guy Briggs wrote:
> On 14/10/29, Greg KH wrote:
> > On Wed, Oct 29, 2014 at 09:35:06AM -0400, Richard Guy Briggs wrote:
> > > When an AUDIT_GET_FEATURE message is sent from userspace to the kernel, it
> > > should reply with a message tagged as an AUDIT_GET_FEATURE type with a struct
> > > audit_feature. The current reply is a message tagged as an AUDIT_GET
> > > type with a struct audit_feature.
> > >
> > > This appears to have been a cut-and-paste-eo in commit b0fed40.
> > >
> > > Reported-by: Steve Grubb <sgrubb@redhat.com>
> > > Cc: stable@vger.kernel.org # v3.13-rc1
> > > Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> > > ---
> > > kernel/audit.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > Why did you send this directly to stable@vger? That's not how to get a
> > patch into the stable kernel trees...
>
> Sorry, you're right. It should be accepted upstream first. I'll go
> back and make sure that gets done...
Wait, it is upstream in v3.18-rc1, commit 9ef9151
Forgot the Cc: to stable in that commit log.
> - RGB
- RGB
--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
prev parent reply other threads:[~2014-10-29 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 13:35 [PATCH]audit: correct AUDIT_GET_FEATURE return message type Richard Guy Briggs
2014-10-29 13:52 ` [PATCH][STABLE] audit: " Paul Moore
2014-10-29 15:50 ` [PATCH]audit: " Greg KH
2014-10-29 16:29 ` [PATCH][STABLE] audit: " Richard Guy Briggs
2014-10-29 18:56 ` Richard Guy Briggs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029185604.GJ20866@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmoore@redhat.com \
--cc=sgrubb@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox