From: Steve Grubb <sgrubb@redhat.com>
To: linux-audit@redhat.com
Subject: Re: Embedded libev library
Date: Sat, 09 Feb 2013 11:23:12 -0500 [thread overview]
Message-ID: <2975310.5k4NdiXIv7@x2> (raw)
In-Reply-To: <20130209161352.677c9c42@fornost.bigon.be>
On Saturday, February 09, 2013 04:13:52 PM Laurent Bigonville wrote:
> I've a question about the embedded version of libev. Is there any
> particular reason you are shipping it?
Yes, it has bug fixes in it. If you have ever dealt with upstream for that
project, then you know how difficult it can be to report bugs.
https://fedorahosted.org/audit/changeset/679
https://fedorahosted.org/audit/changeset/698
I know of one more bug that needs fixing in that library.
>Or is it only for convenience?
Nope. This one in particular breaks the build for audit:
https://fedorahosted.org/audit/changeset/679/trunk/src/libev/ev.h
> The Debian archive is containing already containing libev (4.11) and
> it's usually considered bad practice to embed libraries that are
> already contained in the archive.
>
> Would you accept a patch to allow building audit against the system
> libev library?
Sure. But I want it to default to using the embedded one so there are no
regressions out of the box.
Thanks,
-Steve
next prev parent reply other threads:[~2013-02-09 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-09 15:13 Embedded libev library Laurent Bigonville
2013-02-09 16:23 ` Steve Grubb [this message]
2013-02-09 22:08 ` yersinia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2975310.5k4NdiXIv7@x2 \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox