Linux-audit Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>, Paul Moore <pmoore@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] auparse: do not interpret fE as a capability field
Date: Tue, 13 Jun 2017 08:37:35 -0400	[thread overview]
Message-ID: <3219534.iRscQ7qE3V@x2> (raw)
In-Reply-To: <1497318564-26714-1-git-send-email-rgb@redhat.com>

On Monday, June 12, 2017 9:49:24 PM EDT Richard Guy Briggs wrote:
> The file effective capability is a boolean.  It is being interpreted as the
> capability "chown" by auparse.  Just print its raw value.

Applied. Thanks!

-Steve

> An example from an execve syscall:
> type=BPRM_FCAPS msg=audit(03/07/2017 17:29:56.494:969) : fver=2 fp=sys_admin
> fi=none fe=chown old_pp=none old_pi=none old_pe=none new_pp=sys_admin
> new_pi=none new_pe=sys_admin
> 
> Fixed:
> type=BPRM_FCAPS msg=audit(03/07/2017 17:29:56.494:969) : fver=2 fp=sys_admin
> fi=none fe=1 old_pp=none old_pi=none old_pe=none new_pp=sys_admin
> new_pi=none new_pe=sys_admin
> 
> See: https://github.com/linux-audit/audit-userspace/issues/18
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
>  auparse/typetab.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/auparse/typetab.h b/auparse/typetab.h
> index be82796..32283c6 100644
> --- a/auparse/typetab.h
> +++ b/auparse/typetab.h
> @@ -93,7 +93,6 @@ _S(AUPARSE_TYPE_CAP_BITMAP,	"cap_fi"	)
>  _S(AUPARSE_TYPE_CAP_BITMAP,	"cap_fp"	)
>  _S(AUPARSE_TYPE_CAP_BITMAP,	"fp"		)
>  _S(AUPARSE_TYPE_CAP_BITMAP,	"fi"		)
> -_S(AUPARSE_TYPE_CAP_BITMAP,	"fe"		)
>  _S(AUPARSE_TYPE_CAP_BITMAP,	"old_pp"	)
>  _S(AUPARSE_TYPE_CAP_BITMAP,	"old_pi"	)
>  _S(AUPARSE_TYPE_CAP_BITMAP,	"old_pe"	)

      reply	other threads:[~2017-06-13 12:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13  1:49 [PATCH] auparse: do not interpret fE as a capability field Richard Guy Briggs
2017-06-13 12:37 ` Steve Grubb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3219534.iRscQ7qE3V@x2 \
    --to=sgrubb@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=pmoore@redhat.com \
    --cc=rgb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox