Linux-audit Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] auparse: do not interpret fE as a capability field
@ 2017-06-13  1:49 Richard Guy Briggs
  2017-06-13 12:37 ` Steve Grubb
  0 siblings, 1 reply; 2+ messages in thread
From: Richard Guy Briggs @ 2017-06-13  1:49 UTC (permalink / raw)
  To: linux-audit; +Cc: Richard Guy Briggs

The file effective capability is a boolean.  It is being interpreted as the
capability "chown" by auparse.  Just print its raw value.

An example from an execve syscall:
type=BPRM_FCAPS msg=audit(03/07/2017 17:29:56.494:969) : fver=2 fp=sys_admin fi=none fe=chown old_pp=none old_pi=none old_pe=none new_pp=sys_admin new_pi=none new_pe=sys_admin

Fixed:
type=BPRM_FCAPS msg=audit(03/07/2017 17:29:56.494:969) : fver=2 fp=sys_admin fi=none fe=1 old_pp=none old_pi=none old_pe=none new_pp=sys_admin new_pi=none new_pe=sys_admin

See: https://github.com/linux-audit/audit-userspace/issues/18
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
---
 auparse/typetab.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/auparse/typetab.h b/auparse/typetab.h
index be82796..32283c6 100644
--- a/auparse/typetab.h
+++ b/auparse/typetab.h
@@ -93,7 +93,6 @@ _S(AUPARSE_TYPE_CAP_BITMAP,	"cap_fi"	)
 _S(AUPARSE_TYPE_CAP_BITMAP,	"cap_fp"	)
 _S(AUPARSE_TYPE_CAP_BITMAP,	"fp"		)
 _S(AUPARSE_TYPE_CAP_BITMAP,	"fi"		)
-_S(AUPARSE_TYPE_CAP_BITMAP,	"fe"		)
 _S(AUPARSE_TYPE_CAP_BITMAP,	"old_pp"	)
 _S(AUPARSE_TYPE_CAP_BITMAP,	"old_pi"	)
 _S(AUPARSE_TYPE_CAP_BITMAP,	"old_pe"	)
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] auparse: do not interpret fE as a capability field
  2017-06-13  1:49 [PATCH] auparse: do not interpret fE as a capability field Richard Guy Briggs
@ 2017-06-13 12:37 ` Steve Grubb
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Grubb @ 2017-06-13 12:37 UTC (permalink / raw)
  To: Richard Guy Briggs, Paul Moore; +Cc: linux-audit

On Monday, June 12, 2017 9:49:24 PM EDT Richard Guy Briggs wrote:
> The file effective capability is a boolean.  It is being interpreted as the
> capability "chown" by auparse.  Just print its raw value.

Applied. Thanks!

-Steve

> An example from an execve syscall:
> type=BPRM_FCAPS msg=audit(03/07/2017 17:29:56.494:969) : fver=2 fp=sys_admin
> fi=none fe=chown old_pp=none old_pi=none old_pe=none new_pp=sys_admin
> new_pi=none new_pe=sys_admin
> 
> Fixed:
> type=BPRM_FCAPS msg=audit(03/07/2017 17:29:56.494:969) : fver=2 fp=sys_admin
> fi=none fe=1 old_pp=none old_pi=none old_pe=none new_pp=sys_admin
> new_pi=none new_pe=sys_admin
> 
> See: https://github.com/linux-audit/audit-userspace/issues/18
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
>  auparse/typetab.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/auparse/typetab.h b/auparse/typetab.h
> index be82796..32283c6 100644
> --- a/auparse/typetab.h
> +++ b/auparse/typetab.h
> @@ -93,7 +93,6 @@ _S(AUPARSE_TYPE_CAP_BITMAP,	"cap_fi"	)
>  _S(AUPARSE_TYPE_CAP_BITMAP,	"cap_fp"	)
>  _S(AUPARSE_TYPE_CAP_BITMAP,	"fp"		)
>  _S(AUPARSE_TYPE_CAP_BITMAP,	"fi"		)
> -_S(AUPARSE_TYPE_CAP_BITMAP,	"fe"		)
>  _S(AUPARSE_TYPE_CAP_BITMAP,	"old_pp"	)
>  _S(AUPARSE_TYPE_CAP_BITMAP,	"old_pi"	)
>  _S(AUPARSE_TYPE_CAP_BITMAP,	"old_pe"	)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-13 12:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-13  1:49 [PATCH] auparse: do not interpret fE as a capability field Richard Guy Briggs
2017-06-13 12:37 ` Steve Grubb

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox