From: John Dennis <jdennis@redhat.com>
To: Miloslav Trmac <mitr@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] Fix acct quoting in audit_log_acct_message())
Date: Tue, 04 Mar 2008 10:07:15 -0500 [thread overview]
Message-ID: <47CD65A3.8020204@redhat.com> (raw)
In-Reply-To: <47CCC6F0.1090005@redhat.com>
Miloslav Trmac wrote:
> Hello,
> audit_log_acct_message() is currently quoting acct differently from all
> other users: it adds quotes to acct if it is represented in hexadecimal,
> not when it is represented as-is.
This isn't the only audit hexadecimal parsing issue, there are many
more, see my previous posts. It is a sad fact audit output is impossible
to parse correctly given only the output. Correct parsing of audit data
demands private knowledge about the format of audit log messages on a
per kernel version basis, this is very broken IMHO.
--
John Dennis <jdennis@redhat.com>
next prev parent reply other threads:[~2008-03-04 15:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 3:50 [PATCH] Fix acct quoting in audit_log_acct_message()) Miloslav Trmac
2008-03-04 15:07 ` John Dennis [this message]
2008-03-04 18:10 ` Tomas Mraz
2008-03-04 18:29 ` John Dennis
2008-03-04 19:05 ` Eric Paris
2008-03-05 4:02 ` Valdis.Kletnieks
2008-03-05 13:15 ` Eric Paris
2008-03-04 18:56 ` Steve Grubb
2008-03-04 19:08 ` Miloslav Trmac
2008-03-04 19:28 ` Steve Grubb
2008-03-04 19:15 ` Eric Paris
2008-03-04 20:41 ` John Dennis
2008-03-04 20:29 ` John Dennis
2008-03-04 20:36 ` Tomas Mraz
2008-03-04 20:57 ` John Dennis
2008-03-04 20:43 ` Eric Paris
2008-03-04 20:52 ` Steve Grubb
2008-03-04 21:21 ` John Dennis
2008-03-04 21:38 ` Steve Grubb
2008-03-04 21:55 ` Eric Paris
2008-03-04 22:03 ` Eric Paris
2008-03-04 22:18 ` Steve Grubb
2008-03-04 22:32 ` John Dennis
2008-03-05 14:11 ` John Dennis
2008-03-04 22:14 ` Steve Grubb
2008-03-04 22:21 ` Eric Paris
2008-03-04 23:00 ` Steve Grubb
2008-03-09 18:36 ` Steve Grubb
-- strict thread matches above, loose matches on Subject: below --
2008-03-05 13:55 Miloslav Trmac
2008-03-05 14:11 ` Tomas Mraz
2008-03-05 15:04 ` John Dennis
2008-03-05 15:21 ` Tomas Mraz
2008-03-05 15:29 ` Steve Grubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CD65A3.8020204@redhat.com \
--to=jdennis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=mitr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox