From: "H. Peter Anvin" <hpa@zytor.com>
To: Eric Paris <eparis@redhat.com>, Andy Lutomirski <luto@amacapital.net>
Cc: Richard Guy Briggs <rgb@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-audit@redhat.com
Subject: Re: [PATCH] i386/audit: stop scribbling on the stack frame
Date: Fri, 24 Oct 2014 13:19:46 -0700 [thread overview]
Message-ID: <544AB462.9070708@zytor.com> (raw)
In-Reply-To: <1414093104.2363.14.camel@redhat.com>
On 10/23/2014 12:38 PM, Eric Paris wrote:
>>
>> After the call __audit_syscall_entry aren't they already polluted?
>> Isn't that the reason we need to reload EAX?
>
> Well, I guess EAX is special...
>
Because system calls are "asmlinkage", all the parameters are on the
stack, but %eax is used as the index into the system call table. This
should thus be fine until we get rid of regparm(0) entirely, if that
ever happens.
-hpa
next prev parent reply other threads:[~2014-10-24 20:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 4:04 [PATCH] i386/audit: stop scribbling on the stack frame Eric Paris
2014-10-23 18:39 ` Andy Lutomirski
2014-10-23 19:13 ` H. Peter Anvin
2014-10-23 19:15 ` Eric Paris
2014-10-23 19:20 ` Andy Lutomirski
2014-10-23 19:30 ` Eric Paris
2014-10-23 19:38 ` Eric Paris
2014-10-24 20:19 ` H. Peter Anvin [this message]
2014-10-25 0:00 ` Andy Lutomirski
2014-10-27 2:06 ` Richard Guy Briggs
2014-10-23 20:30 ` Andy Lutomirski
2014-10-24 2:55 ` H. Peter Anvin
2014-10-27 2:01 ` Richard Guy Briggs
[not found] ` <tip-26c2d2b39128adba276d140eefa2745591b88536@git.kernel.org>
[not found] ` <alpine.DEB.2.11.1410251034320.5308@nanos>
2014-10-27 2:34 ` Richard Guy Briggs
2014-10-27 13:55 ` Eric Paris
2014-10-27 17:02 ` H. Peter Anvin
2014-10-27 17:29 ` Eric Paris
2014-10-28 6:30 ` Ingo Molnar
2014-10-27 17:38 ` Richard Guy Briggs
2014-10-27 21:18 ` Thomas Gleixner
2014-10-27 21:22 ` Richard Guy Briggs
2014-10-27 20:52 ` Thomas Gleixner
2014-10-27 21:13 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544AB462.9070708@zytor.com \
--to=hpa@zytor.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=rgb@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox