From: Thomas Gleixner <tglx@linutronix.de>
To: Eric Paris <eparis@redhat.com>
Cc: Richard Guy Briggs <rgb@redhat.com>,
linux-kernel@vger.kernel.org, przanoni@gmail.com,
mingo@kernel.org, hpa@linux.intel.com, hpa@zytor.com,
linux-tip-commits@vger.kernel.org, linux-audit@redhat.com
Subject: Re: [PATCH] i386/audit: stop scribbling on the stack frame
Date: Mon, 27 Oct 2014 22:18:21 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1410272212420.5308@nanos> (raw)
In-Reply-To: <1414418157.24347.1.camel@redhat.com>
On Mon, 27 Oct 2014, Eric Paris wrote:
> My patch was already committed to the -tip urgent branch. I believe any
> optimization should be based on that branch, Richard. If you are trying
> to wrangle every bit of speed out of this, should you
>
> push %esi;
> push %edi;
> CFI_ADJUST_CFA_OFFSET 8
Wrong. You want to use pushl_cfi as you need the CFI adjustment after
each modification of esp.
> call __audit_syscall_entry
> pop;
> pop;
> CFI_ADJUST_CFA_OFFSET -8
>
> Instead of using the pushl_cfi and popl_cfi macros?
Wrong again. See above. Aside of that, why do you want to use pop at
all? All we care about is adjusting esp, right?
Thanks,
tglx
next prev parent reply other threads:[~2014-10-27 21:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 4:04 [PATCH] i386/audit: stop scribbling on the stack frame Eric Paris
2014-10-23 18:39 ` Andy Lutomirski
2014-10-23 19:13 ` H. Peter Anvin
2014-10-23 19:15 ` Eric Paris
2014-10-23 19:20 ` Andy Lutomirski
2014-10-23 19:30 ` Eric Paris
2014-10-23 19:38 ` Eric Paris
2014-10-24 20:19 ` H. Peter Anvin
2014-10-25 0:00 ` Andy Lutomirski
2014-10-27 2:06 ` Richard Guy Briggs
2014-10-23 20:30 ` Andy Lutomirski
2014-10-24 2:55 ` H. Peter Anvin
2014-10-27 2:01 ` Richard Guy Briggs
[not found] ` <tip-26c2d2b39128adba276d140eefa2745591b88536@git.kernel.org>
[not found] ` <alpine.DEB.2.11.1410251034320.5308@nanos>
2014-10-27 2:34 ` Richard Guy Briggs
2014-10-27 13:55 ` Eric Paris
2014-10-27 17:02 ` H. Peter Anvin
2014-10-27 17:29 ` Eric Paris
2014-10-28 6:30 ` Ingo Molnar
2014-10-27 17:38 ` Richard Guy Briggs
2014-10-27 21:18 ` Thomas Gleixner [this message]
2014-10-27 21:22 ` Richard Guy Briggs
2014-10-27 20:52 ` Thomas Gleixner
2014-10-27 21:13 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1410272212420.5308@nanos \
--to=tglx@linutronix.de \
--cc=eparis@redhat.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=przanoni@gmail.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox